Opened 9 years ago

Closed 9 years ago

#348 closed defect (fixed)

remove unnecessary cast from pydnspp binding

Reported by: jinmei Owned by: UnAssigned
Priority: high Milestone: y2 12 month milestone
Component: build system Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity:
Sub-Project: Feature Depending on Ticket:
Estimated Difficulty: 0.0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

Please someone quickly review the attached patch.

I believe it solves the build error for NetBSD:
http://bind10.isc.org/~tester/builder/BIND10/20100922005000-NetBSD5-amd64/logs/build.out

The offending parameters of PyArg_ParseTuple() is the variable argument part, so we should be able to omit the cast in the first place (in fact, I omitted cast for the python binding of the EDNS class in trac #311). In that sense this change should be harmless.

IMO the NetBSD's behavior on this point is deviant (again), but since we can save them for a trivial, harmless change, we should do it.

I don't think we need a changelog entry for this.

Subtickets

Attachments (1)

pydns.diff (4.9 KB) - added by jinmei 9 years ago.

Download all attachments as: .zip

Change History (3)

Changed 9 years ago by jinmei

comment:1 Changed 9 years ago by jinmei

  • Owner changed from jreed to UnAssigned
  • Status changed from new to reviewing

comment:2 Changed 9 years ago by jinmei

  • Resolution set to fixed
  • Status changed from reviewing to closed

reviewed on jabber, fix committed with a few suggested changes.

from jabbeer log:

06:03:09y-aharenI don't have permission to comment on a ticket...
06:24:43jinmeiah, good catch. I grepped for "PyObject?" and missed some cases where "PyObject?* *" was used.
06:25:52jinmeiI've just grepped for "PyArg_ParseTuple" and examined and fixed all unnecessary casts.

now closing the ticket.

Note: See TracTickets for help on using tickets.