Opened 6 years ago

Closed 6 years ago

#3473 closed enhancement (fixed)

be prepared for OS X 10.9.4

Reported by: fdupont Owned by: fdupont
Priority: low Milestone: Kea0.9
Component: Unclassified Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 1 Internal?: no

Description

replace the if cases in configure.ac by a switch (case in shell).

BTW I proposed this because I had to fix it in #2406 for 10.9.3
(2406km branch was forked with up to 10.9.2 handling).

Subtickets

Change History (15)

comment:1 Changed 6 years ago by fdupont

I keep the ticket until #2406 is merged.

comment:2 Changed 6 years ago by fdupont

10.9.4 is announced so it is time!!!

comment:3 Changed 6 years ago by fdupont

  • Priority changed from low to high

comment:4 Changed 6 years ago by tomek

Moving to 0.9 release as discussed on Kea meeting (2014-07-02), but since this should not block the release or affect schedules, priority is set to low.

comment:5 follow-up: Changed 6 years ago by tomek

Jeremy had a comment about this. The script should be updated to not explicitly mention all Mac OS version numbers.

comment:6 in reply to: ↑ 5 Changed 6 years ago by fdupont

Replying to tomek:

Jeremy had a comment about this. The script should be updated to not explicitly mention all Mac OS version numbers.

=> I agree but how to do it? I upgraded my OS X to 10.9.4 so I have everything needed to find/fix/check...

comment:7 Changed 6 years ago by fdupont

Done (I use the Availability.h macros to check if the OS X version is >= 10.9. Works fine if not cross compiling).

comment:8 Changed 6 years ago by fdupont

  • Owner changed from fdupont to UnAssigned
  • Status changed from new to reviewing

comment:9 Changed 6 years ago by fdupont

Ready for review (BTW 10.9.4 is available so IMHO we should bump the priority!)

comment:10 Changed 6 years ago by tomek

  • Milestone changed from Kea-proposed to Kea0.9
  • Priority changed from high to low

comment:11 Changed 6 years ago by stephen

  • Owner changed from UnAssigned to stephen

comment:12 follow-up: Changed 6 years ago by stephen

  • Owner changed from stephen to fdupont

Reviewed commit 882396cb87b5a84cd98a1d107252ac1de1918ec7

All OK - Kea builds on 10.9.4. If this also works with OS X versions earlier than 10.9.4 (I don't have such a version available), please merge.

comment:13 in reply to: ↑ 12 Changed 6 years ago by fdupont

Replying to stephen:

Reviewed commit 882396cb87b5a84cd98a1d107252ac1de1918ec7

All OK - Kea builds on 10.9.4. If this also works with OS X versions earlier than 10.9.4 (I don't have such a version available), please merge.

=> I moved all my OS X to 10.9.4 (Apple usually puts security fixes only in the last version (last two versions in the best case) so it is never a good idea to run an old version when the choice is possible). BTW a 10.9* will share the same SDK so only 10.8* (or older) can make a difference. What is the OS X version used by the test box(es)?
I'll merge anyway as the current code breaks on 10.9.4.

comment:14 Changed 6 years ago by fdupont

Built a 10.8 VM for regression testing (with success). Merged. Closing...

comment:15 Changed 6 years ago by fdupont

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.