Opened 6 years ago

Closed 5 years ago

#3459 closed defect (complete)

Invalid b10-dhcp error mesage when configuration file name not specified

Reported by: marcin Owned by: stephen
Priority: medium Milestone: Kea0.9
Component: dhcp Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: Low
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 1
Total Hours: 1 Internal?: no

Description

When starting b10-dhcp4 or b10-dhcp6 the following output is presented:

Failed to initialize server: Unable to process JSON configuration file:

It is wrong. It should say:

Failed to initialize the server: configuration file not specified. Use [-c cfgfile].

Subtickets

Change History (6)

comment:1 Changed 6 years ago by tomek

  • Milestone changed from Kea-proposed to Kea0.9
  • Priority changed from low to medium

comment:2 Changed 5 years ago by marcin

  • Owner changed from UnAssigned to marcin
  • Status changed from new to accepted

comment:3 Changed 5 years ago by marcin

  • Add Hours to Ticket changed from 0 to 1
  • Owner changed from marcin to UnAssigned
  • Status changed from accepted to reviewing
  • Total Hours changed from 0 to 1

I added check right after parsing command line option if the configuration file has been specified. If not, the process prints an error message, usage and terminates.

I also spotted other issue and submitted the ticket http://kea.isc.org/ticket/3501 to address it.

comment:4 Changed 5 years ago by marcin

This change is straight forward and review should take no longer than 10 minutes. During my absence the reviewer may probably just fix whatever he things is wrong and merge by himself.

comment:5 Changed 5 years ago by stephen

  • Owner changed from UnAssigned to stephen

comment:6 Changed 5 years ago by stephen

  • Resolution set to complete
  • Status changed from reviewing to closed

Reviewed commit 35860175e8fc5e57519f9756144f669c091404df

All OK, so as Marcin has requested I have merged this change. As the change is small, I do not believe it needs a ChangeLog entry.

Note: See TracTickets for help on using tickets.