Opened 5 years ago
Last modified 3 years ago
#3452 new defect
Kea doesn't validate renew-timer, rebind-timer and lifetimes being configured
| Reported by: | marcin | Owned by: | |
|---|---|---|---|
| Priority: | low | Milestone: | Outstanding Tasks |
| Component: | remote-management | Version: | git |
| Keywords: | Cc: | ||
| CVSS Scoring: | Parent Tickets: | ||
| Sensitive: | no | Defect Severity: | Low |
| Sub-Project: | Mozilla | Feature Depending on Ticket: | |
| Estimated Difficulty: | 0 | Add Hours to Ticket: | 0 |
| Total Hours: | 0 | Internal?: | no |
Description (last modified by tomek)
Neither Kea4 nor Kea6 validates the timers configured. For example, it is possible to enter renew-timer > rebind-timer which is wrong.
The fix is not trivial because we somehow need to extract the culprit line number and print it out in the log message. Since we are using inheritance it is not even clear in the config parser if the wrong value comes from the global config scope or from the subnet.
I think it should be fixed in the 1.0 time frame.
Subtickets
Change History (18)
comment:1 Changed 5 years ago by tomek
- Milestone changed from Kea-proposed to Kea1.0
comment:2 Changed 5 years ago by tomek
- Milestone changed from Kea1.0 to Kea0.9.1
- Version set to git
comment:3 Changed 5 years ago by hschempf
- Milestone changed from Kea0.9.1 to Kea0.9.2
comment:4 Changed 5 years ago by hschempf
- Priority changed from medium to low
comment:5 Changed 4 years ago by tomek
- Milestone changed from Kea0.9.2 to Kea0.9.2-final
comment:6 Changed 4 years ago by marcin
- Priority changed from low to very high
comment:7 Changed 4 years ago by marcin
- Priority changed from very high to very low
comment:8 Changed 4 years ago by fdupont
There are at least 3 different points:
- what should be the checks (easy).
- where to put them (parsing itself (build) or after parsing (commit) or even after) (IMHO there is no reason to be late)
- emit error messages which can be understood (vs cryptic) and which are useful (vs not enough context) (Element has a position property which does the half of this requirement).
My opinion is the check should be done in the commit phase (because it is not a syntax problem) using some context to solve the issue noted in the description.
BTW the check should be renew <= rebind <= expire, shouldn't be?
comment:9 Changed 4 years ago by marcin
- Milestone changed from Kea0.9.2 to Kea1.0
- Priority changed from very low to medium
Moving to 1.0 medium as per tickets scrub on 07/31/2015.
comment:10 Changed 4 years ago by stephen
- Milestone changed from Kea1.0 to DHCP Outstanding Tasks
Per Kea planning meeting in October, move out of 1.0.
comment:11 Changed 4 years ago by tomek
- Milestone changed from DHCP Outstanding Tasks to Outstanding Tasks
Milestone renamed
comment:12 Changed 3 years ago by tomek
- Description modified (diff)
- Milestone changed from Outstanding Tasks to Kea1.2
comment:13 Changed 3 years ago by tomek
- Component changed from dhcpconf to configuration
comment:14 Changed 3 years ago by tomek
- Priority changed from medium to low
comment:15 Changed 3 years ago by tomek
- Component changed from configuration to remote-management
comment:16 Changed 3 years ago by tomek
- Sub-Project changed from DHCP to Mozilla
comment:17 Changed 3 years ago by tomek
- Milestone changed from Kea1.2 to Kea1.2-final
Code freeze for 1.2-beta. Moving all remaining open tickets to 1.2-final.
comment:18 Changed 3 years ago by tomek
- Milestone changed from Kea1.2-final to Outstanding Tasks
As discussed on 2017-04-13 call, moving to outstanding.
Moving to "very-low" per post-beta 0.9.2 tickets scrub.