Opened 9 years ago

Closed 9 years ago

#344 closed enhancement (fixed)

test data for lib/config

Reported by: jinmei Owned by: jinmei
Priority: low Milestone: y2 12 month milestone
Component: build system Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity:
Sub-Project: Feature Depending on Ticket:
Estimated Difficulty: 0.0 Add Hours to Ticket: 0
Total Hours: 0.32 Internal?: no

Description

Test data for src/lib/config is now under src/lib/config/testdata.

It should better be under src/lib/config/tests/testdata for consistency.

Subtickets

Change History (8)

comment:1 Changed 9 years ago by jinmei

  • Owner changed from jreed to jinmei
  • Status changed from new to assigned

comment:2 follow-up: Changed 9 years ago by jinmei

  • Add Hours to Ticket changed from 0.0 to 0.32
  • Owner changed from jinmei to UnAssigned
  • Status changed from assigned to reviewing
  • Total Hours changed from 0.0 to 0.32

Please review branches/trac344. This should be quite trivial.

comment:3 in reply to: ↑ 2 Changed 9 years ago by jinmei

Replying to jinmei:

Please review branches/trac344. This should be quite trivial.

(forgo to say this) I think this is so minor that we don't need a changelog entry for it.

comment:4 Changed 9 years ago by vorner

  • Owner changed from UnAssigned to vorner

comment:5 follow-up: Changed 9 years ago by vorner

  • Owner changed from vorner to jinmei

The src/lib/config/Makefile.am seems to still reference the testdata/* in EXTRA_DIST. I think they should be moved to the testdata Makefile.am.

comment:6 in reply to: ↑ 5 Changed 9 years ago by jinmei

  • Owner changed from jinmei to vorner

Replying to vorner:

The src/lib/config/Makefile.am seems to still reference the testdata/* in EXTRA_DIST. I think they should be moved to the testdata Makefile.am.

Ah, good point. Fixed in r3097. Is that okay?

comment:7 follow-up: Changed 9 years ago by vorner

  • Owner changed from vorner to jinmei

Yes, it seems ok now. I think it can be merged.

comment:8 in reply to: ↑ 7 Changed 9 years ago by jinmei

  • Resolution set to fixed
  • Status changed from reviewing to closed

Replying to vorner:

Yes, it seems ok now. I think it can be merged.

thanks, committed. closing.

Note: See TracTickets for help on using tickets.