Opened 6 years ago

Closed 6 years ago

#3417 closed enhancement (complete)

Remove references to BIND10 in .cc and .h files

Reported by: tomek Owned by: tomek
Priority: medium Milestone: Kea0.9
Component: Unclassified Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 1
Total Hours: 0 Internal?: no

Description

Do another pass through the .cc and .h files and remove references
to BIND 10.

Subtickets

Change History (5)

comment:1 Changed 6 years ago by tomek

  • Owner set to tomek
  • Status changed from new to assigned

comment:2 Changed 6 years ago by tomek

  • Owner changed from tomek to UnAssigned
  • Status changed from assigned to reviewing

I left BIND10 references in several placed where it is useful for historical context or when the code is BIND10 specific, but we haven't removed it yet. Here's the list of those places:

getRelatedLoggers() in src/lib/config/ccsession.h. It talks about dependency between module names and logger names. b10-resolver and b10-auth is used as an example, but I thought these were completely independent modules (was was recursive resolver while the other was authoritative). I'm not sure if that code has any practical use for us. Once 0.9 is released, we should reevaluate if we want to keep Bundy backend or not.

'b10' string is present in many hex strings, mostly in HMAC tests.

There are still some variables in configure.ac that use BIND10. This is clearly outside of the scope for this ticket.

The code is ready for review.

comment:3 Changed 6 years ago by tmark

  • Owner changed from UnAssigned to tmark

comment:4 Changed 6 years ago by tmark

  • Add Hours to Ticket changed from 0 to 1
  • Owner changed from tmark to tomek

Only a couple of minor things:

+% DCTL_DISCONNECT_FAIL %1 controller failed to end session with Bundy: %2

This message indicates that while shutting down, the DHCP-DDNS controller
encountered an error terminating communication with the Kea configuration
system. The service will still exit. While theoretically possible,

The message description should say "Bundy" not "Kea configuration system". This message only used in bundy_d2_controller and hence only applies to Bundy connectivity.


in src/bin/dhcp4/main.cc

+/ component for Kea software suite. It parses command-line arguments and

should be "of Kea software suite" not "for Kea software suite"

  • Similiar item for dhcp6

You should create a ticket the scrub BIND10/B10 from configure.ac


Unit test pass, make distcheck works. I do not need to see this ticket again.

comment:5 Changed 6 years ago by tomek

  • Resolution set to complete
  • Status changed from reviewing to closed

Thanks for the review. Updated as suggested. Code merged and pushed. Closing ticket.

Note: See TracTickets for help on using tickets.