Opened 6 years ago

Last modified 4 years ago

#3318 new task

Add builder that uses -ftrapv flag on g++

Reported by: shane Owned by: jreed
Priority: very low Milestone: Outstanding Tasks
Component: build system Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DNS Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

We recently updated the code to not depend on behavior of signed integer overflow in ticket #3010.

We do not set the -ftrapv flag which revealed this problem because there is a runtime cost.

However, we should run our tests in an environment to insure that we don't add any code that violates this constraint. This ticket is to set up such a builder.

Subtickets

Change History (4)

comment:1 Changed 6 years ago by tomek

  • Milestone changed from New Tasks to Common Outstanding Tasks

Milestone New Tasks deleted

comment:2 Changed 4 years ago by tomek

  • Milestone changed from Common Outstanding Tasks to DHCP Outstanding Tasks
  • Priority changed from medium to very low
  • Version set to git

I'm not aware of any cases of dependance on signed integer overflow, but there may be some that I'm not aware of. Let's move this to DHCP Outstanding as very low.

comment:3 Changed 4 years ago by fdupont

There are a large number of signed/unsigned and integer size mismatches in the code. It is not clear they all should be addressed but it is unrealistic to deny they exist (:-).
BTW I have the logs of the build under WIN32 with this kind of warnings so the day we want to cleanup them... IMHO it is not bad to have a code compiling without warnings (aka -Werror), of course without disabling too many warnings without caution.
If you need examples: NetBSD is a system where -Werror is set by default, bind9 a big software which is compiled with a very few warnings (usually none with recent platforms and compilers).

comment:4 Changed 4 years ago by tomek

  • Milestone changed from DHCP Outstanding Tasks to Outstanding Tasks

Milestone renamed

Note: See TracTickets for help on using tickets.