Opened 6 years ago

Last modified 3 years ago

#3306 new defect

Implement subnet overlapping sanity check

Reported by: tomek Owned by:
Priority: low Milestone: Outstanding Tasks
Component: remote-management Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: Low
Sub-Project: Mozilla Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description (last modified by tomek)

Currently it is possible to define overlapping subnets (or even multiple copies of the same subnet). Doing so would lead to non-obvious errors (like lease being free, but not being able to use it or lease belonging to the wrong subnet).

See CfgMgr::addSubnet{4,6} in src/lib/dhcpsrv/cfgmgr.cc.

Subtickets

Change History (16)

comment:1 Changed 6 years ago by tomek

  • Priority changed from medium to low

Accepting in 0.9-alpha with low priority (as discussed on Kea call, 2014-01-29).

comment:2 Changed 6 years ago by tomek

  • Milestone changed from DHCP-Kea-proposed to DHCP-Kea0.9-alpha

comment:3 Changed 6 years ago by stephen

  • Milestone changed from DHCP-Kea0.9-alpha to DHCP-Kea0.9-beta

comment:4 Changed 6 years ago by tomek

  • Milestone changed from DHCP-Kea0.9 to DHCP-Kea-proposed

comment:5 Changed 5 years ago by tomek

  • Milestone changed from Kea-proposed to Kea1.0

comment:6 Changed 4 years ago by stephen

  • Milestone changed from Kea1.0 to DHCP Outstanding Tasks
  • Version set to git

Per Kea planning session in October, moved out of 1.0.

comment:7 Changed 4 years ago by tomek

  • Milestone changed from DHCP Outstanding Tasks to Outstanding Tasks

Milestone renamed

comment:8 Changed 3 years ago by tomek

  • Description modified (diff)
  • Milestone changed from Outstanding Tasks to Kea1.2

comment:9 Changed 3 years ago by tomek

  • Component changed from dhcpconf to configuration

comment:10 Changed 3 years ago by tomek

  • Component changed from configuration to remote-management

comment:11 Changed 3 years ago by fdupont

Reference is obsolete so the real problem is unclear...

comment:12 Changed 3 years ago by tomek

  • Sub-Project changed from DHCP to Mozilla

comment:13 Changed 3 years ago by tomek

An example of overlapping subnets:
10.0.0.0/8
10.1.0.0/24
(the second one is within the first one)

comment:14 Changed 3 years ago by fdupont

Overlapping subnets don't mean the subnet selection will be ambiguous because there are many ways where another thing is used:

  • client classes (systematic try next)
  • relay (highest priority)
  • interface (another potential source of ambiguity)
  • hooks (when the selector is not in Kea code)

In fact the only clear error case is with two identical subnet configurations!

So now I understand what is overlapping subnets but not (yet) what the code addressing this ticket is supposed to do...

comment:15 Changed 3 years ago by tomek

  • Milestone changed from Kea1.2 to Kea1.2-final

Code freeze for 1.2-beta. Moving all remaining open tickets to 1.2-final.

comment:16 Changed 3 years ago by tomek

  • Milestone changed from Kea1.2-final to Outstanding Tasks

As discussed on 2017-04-13 call, moving to outstanding.

Note: See TracTickets for help on using tickets.