Opened 6 years ago

Closed 6 years ago

#3300 closed defect (fixed)

libb10-log failure with --enable-debug

Reported by: muks Owned by: muks
Priority: very high Milestone: Sprint-20131015
Component: logging Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DNS Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

libb10-log unittests fail with --enable-debug on master.

I haven't checked if it is something local to the src/lib/log/tests/ directory or affects libb10-log itself. From the logged message, it may be something trivial but necessary. This should be fixed at a high priority:

/bin/sh /home/muks/bind10/src/lib/log/tests/buffer_logger_test.sh
bufferLogger test
1. Checking that buffer initialization works
   - Buffer including process() call: 2a3
> Appender did not call destructorImpl().
 FAIL
   - Buffer excluding process() call: 3a4
> log4cplus:ERROR Derived Appender did not call destructorImpl().
 FAIL

Subtickets

Change History (6)

comment:1 Changed 6 years ago by muks

  • Owner set to muks
  • Status changed from new to assigned

comment:2 Changed 6 years ago by muks

Up for review. The change was simple but necessary. It's good that log4cplus has added checks to ensure that we use the library correctly.

There is a slight chance that this won't work with very old versions of log4cplus. I have checked that it will also work on log4cplus-1.1.0. The check is in log4cplus-1.2.0 and above.

Will put it to the builders now.

comment:3 Changed 6 years ago by muks

No ChangeLog is necessary unless it fixes any of the log4cplus problems we have been observing. I'll ask Jeremy about this.

comment:4 Changed 6 years ago by muks

  • Owner changed from muks to UnAssigned
  • Status changed from assigned to reviewing

comment:5 Changed 6 years ago by pselkirk

  • Owner changed from UnAssigned to muks

Okay to merge.

comment:6 Changed 6 years ago by muks

  • Resolution set to fixed
  • Status changed from reviewing to closed

Merged to master branch in commit 34564befb89523c4d2f1faca4b5891e07d0d132f:

* da04dd3 [3300] Call destructorImpl() in our Appender class's destructor

Resolving as fixed. Thank you for the review Paul.

Note: See TracTickets for help on using tickets.