Opened 6 years ago

Closed 4 years ago

#3296 closed enhancement (complete)

Rethink Pkt4 and Pkt6 class hierarchy

Reported by: tomek Owned by:
Priority: medium Milestone: Kea1.0
Component: dhcp Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description (last modified by tomek)

There are many similarities between Pkt4 and Pkt6, but they do not have a common base class. Furthermore, some methods in both classes are server-specific (e.g. relay manipulation code) that would be useless on the client side.

We should rethink the class hierarchy here. One possible way forward would be:

BasePkt?->Pkt4->SrvPkt4
BasePkt?->Pkt6->SrvPkt6

Subtickets

Change History (3)

comment:1 Changed 6 years ago by tomek

  • Type changed from defect to enhancement

comment:2 Changed 4 years ago by tomek

  • Milestone changed from DHCP Outstanding Tasks to Outstanding Tasks

Milestone renamed

comment:3 Changed 4 years ago by tomek

  • Description modified (diff)
  • Milestone changed from Outstanding Tasks to Kea1.0
  • Resolution set to complete
  • Status changed from new to closed
  • Version set to git

We do have base Pkt class now. Closing.

Note: See TracTickets for help on using tickets.