Opened 9 years ago

Closed 9 years ago

#329 closed defect (fixed)

When xfrin can't connect to its master, it should also the bad news to zonemgr.

Reported by: zhanglikun Owned by: UnAssigned
Priority: medium Milestone:
Component: xfrin Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity:
Sub-Project: Feature Depending on Ticket:
Estimated Difficulty: 1.0 Add Hours to Ticket: 0
Total Hours: 2.0 Internal?: no

Description

When xfrin can't connect to its master, it should also the bad news to zonemgr, so that zonemgr can reset the zone's refresh time .

Subtickets

Change History (7)

comment:1 Changed 9 years ago by zhanglikun

  • Add Hours to Ticket changed from 0.0 to 2.0
  • Total Hours changed from 0.0 to 2.0

comment:2 Changed 9 years ago by zhanglikun

  • Estimated Difficulty changed from 0.0 to 1.0
  • Owner changed from zhanglikun to jreed
  • Status changed from new to reviewing

Hi jeremy, the patch has been committed to branch trac329, would you like to have a review.

comment:3 Changed 9 years ago by jreed

This looks fine. (I didn't try to reproduce.) You may want to add comment(s) in process_xfrin() explaining this behavior. I do see docs for publish_xfrin_news() but I don't understand yet if xfrin itself will forget about it until receives a new command from zonemgr.

comment:4 Changed 9 years ago by jreed

Also the unittests already covered these lines of code, but should there be separate specific unit tests for conn.connect_to_master() success and failure?

comment:5 Changed 9 years ago by zhanglikun

conn.connect_to_master() has been changed in trac216(to be merged to trunk), so I don't plan to add the test case to it. see the latest change in branch329.

comment:6 Changed 9 years ago by jreed

  • Owner changed from jreed to UnAssigned

I did not look again, but according to comments, this is okay now.

comment:7 Changed 9 years ago by zhanglikun

  • Resolution set to fixed
  • Status changed from reviewing to closed

Committed to trunk in r3170 and r3171. Close this ticket now.

Note: See TracTickets for help on using tickets.