Opened 9 years ago

Closed 9 years ago

#325 closed defect (fixed)

./configure --help talks about options that do not work

Reported by: vorner Owned by: jinmei
Priority: low Milestone:
Component: build system Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity:
Sub-Project: Feature Depending on Ticket:
Estimated Difficulty: 0.0 Add Hours to Ticket: 0
Total Hours: 1.9 Internal?: no

Description

When you run ./configure --disable-static, the make fails then, however --help mentions it. If we do not support static build, we should remove the option somehow.

The CXXFLAGS variable has no effect, since it is overwritten unconditionally with -g in configure. Shouldn't -g be just a default when nothing is set?

Subtickets

Change History (4)

comment:1 Changed 9 years ago by jinmei

  • Add Hours to Ticket changed from 0.0 to 1.9
  • Total Hours changed from 0.0 to 1.9

comment:2 in reply to: ↑ description Changed 9 years ago by jinmei

  • Owner changed from jreed to vorner
  • Status changed from new to reviewing

Replying to vorner:

When you run ./configure --disable-static, the make fails then, however --help mentions it. If we do not support static build, we should remove the option somehow.

The CXXFLAGS variable has no effect, since it is overwritten unconditionally with -g in configure. Shouldn't -g be just a default when nothing is set?

I believe I fixed these in r2976. I intended to make it in a separate branch, but I accidentally committed it to trunk (I used git-svn interface and I failed to manage it correctly). I think the diff is pretty straightforward and leave the change in trunk for now. But could you review it anyway?

The proposed changelog entry is as follows:

  96.	[build]		jinmei
	Fixed two small issues with configure: Do not set CXXFLAGS so that
	it can be customized; Made sure --disable-static works.
	(Trac #325, r2976)

comment:3 follow-up: Changed 9 years ago by vorner

  • Owner changed from vorner to jinmei

Seems ok, just the [build] in changelog ‒ I didn't find it in the changelog guide and this seems like a bugfix to me, not a new feature or change in build system, so, may I suggest [bug] instead?

comment:4 in reply to: ↑ 3 Changed 9 years ago by jinmei

  • Resolution set to fixed
  • Status changed from reviewing to closed

Replying to vorner:

Seems ok, just the [build] in changelog ‒ I didn't find it in the changelog guide and this seems like a bugfix to me, not a new feature or change in build system, so, may I suggest [bug] instead?

Okay. Committed the changelog entry. Closing ticket.

Note: See TracTickets for help on using tickets.