Opened 6 years ago

Last modified 4 years ago

#3229 new enhancement

Need better tests for activating interfaces

Reported by: tomek Owned by:
Priority: low Milestone: Outstanding Tasks
Component: libdhcp Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

During dry-run we discovered that activating ipv6 interface was not functional, because we set active4_ field, not active6_. This is fixed already, but it shows that our tests in that area are inadequate.

It is unclear if this can be addressed with unit-tests or system tests would be better.

Subtickets

Change History (6)

comment:1 Changed 6 years ago by tomek

Also see #3195.

comment:2 Changed 6 years ago by tomek

  • Milestone changed from DHCP Outstanding Tasks to DHCP-Kea1.0-alpha
  • Priority changed from medium to low

comment:3 Changed 6 years ago by marcin

A few other related modifications should be considered as a part of this ticket or implemented as a separate ticket:

  • openActiveInterfaces from DHCPv4 and DHCPv6 server code should be moved to CfgMgr as these functions depend solely on IfaceMgr and CfgMgr, not on the DHCPvX server code!
  • There may be some field for unification of both functions in the CfgMgr.
  • The missing unit tests should be then implemented under src/lib/dhcpsrv to avoid bloat of unit tests in the src/bin/dhcpX.
  • When opening a socket on interface for which there is no subnet configured, a warning or info log message should be issued. This was considered to be implemented with #3242 but since openActiveInterfaces functions are likely to be moved to CfgMgr, it probably makes more sense to add this warning message after they are moved.

comment:4 Changed 6 years ago by stephen

  • Milestone changed from DHCP-Kea0.9-alpha to DHCP-Kea0.9-beta

comment:5 Changed 6 years ago by tomek

  • Milestone changed from DHCP-Kea0.9 to DHCP Outstanding Tasks

comment:6 Changed 4 years ago by tomek

  • Milestone changed from DHCP Outstanding Tasks to Outstanding Tasks

Milestone renamed

Note: See TracTickets for help on using tickets.