Opened 6 years ago

Closed 6 years ago

#3211 closed defect (fixed)

Kea does not parse IAPREFIX properly

Reported by: tomek Owned by: tomek
Priority: high Milestone: Sprint-DHCP-20131016
Component: dhcp6 Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

It seems that Kea does not parse incoming IAPREFIX correctly and creates a generic object, rather than Option6IAPrefix.

Subtickets

Change History (4)

comment:1 Changed 6 years ago by tomek

  • Owner set to UnAssigned
  • Status changed from new to reviewing

Code fix developed, ready for review.

comment:2 Changed 6 years ago by marcin

  • Owner changed from UnAssigned to marcin

comment:3 Changed 6 years ago by marcin

  • Owner changed from marcin to tomek

Reviewed commit fab2fd65c02fe2e215a004b094916c449f6d994c

ChangeLog
Suggest that you mention that IAPREFIX is a DHCPv6 option.

option_definition.h
factoryIAPrefix6: The comment ''if provided option buffer is too short or too long'' is wrong. You just check that the option buffer isn't too short.

Also it should be: ''Expected minimum size is 25 bytes''.

Also the part about BadValue is wrong because no universe is being specified.

I admit that similar comments for other functions may be wrong too and this may be my fault :-)

comment:4 Changed 6 years ago by tomek

  • Resolution set to fixed
  • Status changed from reviewing to closed

Thanks for extra fast review. Fixed, pushed, closed.

Note: See TracTickets for help on using tickets.