Opened 10 years ago

Closed 9 years ago

Last modified 9 years ago

#319 closed task (fixed)

outdated(?) comment in ccsession.py: no UICCSession class

Reported by: jinmei Owned by: jelte
Priority: low Milestone:
Component: configuration Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity:
Sub-Project: Feature Depending on Ticket:
Estimated Difficulty: 0.0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

ccsession.py mentions a class called "UICCSession":

   This module provides the ModuleCCSession and UICCSession classes,
   as well as a set of utility functions to create and parse messages
   related to commands and configuration
   ...

but it's not defined anywhere in the source tree.

I suspect it's a leftover from some preliminary version of the code and should be cleaned up.

I'm giving this ticket to the person who I believe is most appropriate for this topic:-)

Subtickets

Change History (7)

comment:1 follow-up: Changed 9 years ago by jelte

  • Owner changed from jelte to jinmei
  • Status changed from new to reviewing

Yeah, I had changed the names, and left in two occurrences in the docstring. Did a search and replace.

branch trac319, commit 7a264c3e91a77fed53fd305d799db6b4f671108a

assigning review to reporter, should be a 3-second check :)

comment:2 in reply to: ↑ 1 Changed 9 years ago by jinmei

Replying to jelte:

Yeah, I had changed the names, and left in two occurrences in the docstring. Did a search and replace.

branch trac319, commit 7a264c3e91a77fed53fd305d799db6b4f671108a

assigning review to reporter, should be a 3-second check :)

Looks okay. (I'd even skip an explicit review for such a trivial
change:-)

comment:3 Changed 9 years ago by jinmei

  • Owner changed from jinmei to vorner

comment:4 Changed 9 years ago by jinmei

  • Owner changed from vorner to jelte

comment:5 Changed 9 years ago by jinmei

(sorry, reassigned it to the wrong person. corrected.)

comment:6 Changed 9 years ago by jelte

  • Resolution set to fixed
  • Status changed from reviewing to closed

Merged. Yeah I know this didn't need a review, but I didn't want to wait around on jabber to ask for confirmation, and this gave me a good opportunity to try out the push.default setting :)

comment:7 Changed 9 years ago by stephen

  • Milestone feature backlog item deleted

Milestone feature backlog item deleted

Note: See TracTickets for help on using tickets.