Opened 9 years ago

Closed 9 years ago

#316 closed defect (fixed)

make check continues even if check-local intermediate test case fails

Reported by: jreed Owned by: jreed
Priority: medium Milestone:
Component: build system Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity:
Sub-Project: Feature Depending on Ticket:
Estimated Difficulty: 0.0 Add Hours to Ticket: 0
Total Hours: 1.0 Internal?: no

Description

The loop running the python tests returns success even if one of the tests fails.

(Jinmei reported this on jabber and provided an example solution in r2766.)

Subtickets

Change History (4)

comment:1 Changed 9 years ago by jreed

I made branch trac316 and r2771 is my commit. Note I didn't store return exit code for failing script, but just exit immediately if script fails.

comment:2 Changed 9 years ago by jreed

  • Component changed from Unclassified to build system

comment:3 follow-up: Changed 9 years ago by jinmei

  • Status changed from new to reviewing

It basically looks okay. Some minor comments:

  • I don't know why correct_test.sh was excluded
  • in any case such a change should go to a separate ticket
  • the second point applies to bind10's args_test, too
  • There seemst to be grammar error in this comment
    # TODO: this is a not a python script! 
    
    maybe it should be "this is not a python script"?

comment:4 in reply to: ↑ 3 Changed 9 years ago by jreed

  • Add Hours to Ticket changed from 0.0 to 1.0
  • Resolution set to fixed
  • Status changed from reviewing to closed
  • Total Hours changed from 0.0 to 1.0

Replying to jinmei:

It basically looks okay. Some minor comments:

  • I don't know why correct_test.sh was excluded

Accidently committed. I removed in next commit.

  • in any case such a change should go to a separate ticket
  • the second point applies to bind10's args_test, too
  • There seemst to be grammar error in this comment
    # TODO: this is a not a python script! 
    
    maybe it should be "this is not a python script"?

I removed the unrelated comments.

This was now committed to trunk in r2799

Note: See TracTickets for help on using tickets.