Opened 9 years ago

Closed 9 years ago

#315 closed defect (fixed)

test b10-config.db should be built on builddir

Reported by: jinmei Owned by: UnAssigned
Priority: low Milestone: y2 6 month milestone
Component: build system Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity:
Sub-Project: Feature Depending on Ticket:
Estimated Difficulty: 0.0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

because cfgmgr_test (under lib/python) will override b10-config.db.

It will break dist-check. It's also undesirable as this file is managed by svn. So if there were a bug that really alters the content of the file it would cause repository change.

Subtickets

Change History (4)

comment:1 Changed 9 years ago by jinmei

branches/trac315 is ready for review.

It also adds some minor improvement: making sure an intemediate errro in python config tests will be treated as a fatal test error.

This is a proposed ChangeLog entry:

  89.	[build]		jinmei
	Generate b10-config.db for tests at build time so that the source
	tree does not have to be writable. (Trac #315, rTBD)

comment:2 Changed 9 years ago by jinmei

  • Owner changed from jreed to UnAssigned
  • Status changed from new to reviewing

comment:3 follow-up: Changed 9 years ago by jreed

This works good for me. I made one minor fix to your branch: r2774
Okay to commit to trunk.

comment:4 in reply to: ↑ 3 Changed 9 years ago by jinmei

  • Resolution set to fixed
  • Status changed from reviewing to closed

Replying to jreed:

This works good for me. I made one minor fix to your branch: r2774
Okay to commit to trunk.

Done, closing ticket.

Note: See TracTickets for help on using tickets.