Opened 7 years ago

Closed 7 years ago

#3048 closed defect (fixed)

Remove log messages from ServerHooks methods used during hook registration

Reported by: stephen Owned by: stephen
Priority: medium Milestone: Sprint-DHCP-20130717
Component: dhcp Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: Core Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description (last modified by stephen)

One technique recommended for initializing the list of hooks in a server involves the use of static initialization functions. However, the presence of logging messages in the ServerHooks constructor and registerHooks() method prevents this because logging is not initialized at this stage.

This ticket removes two messages (one a debug message and one a warning message) to allow the technique to work.

Subtickets

Change History (5)

comment:1 Changed 7 years ago by stephen

  • Owner set to stephen
  • Status changed from new to accepted

comment:2 Changed 7 years ago by stephen

  • Description modified (diff)
  • Owner changed from stephen to UnAssigned
  • Status changed from accepted to reviewing

Ready for review. The first commit makes the changes to the code. The second is a cosmetic change, reordering the message file into alphabetical order.

comment:3 Changed 7 years ago by tomek

  • Owner changed from UnAssigned to tomek

comment:4 Changed 7 years ago by tomek

  • Owner changed from tomek to stephen

server_hooks.cc

Comment before ServerHooks? constructor: "One method to initialize hook names is to use static initialization.". It should say "The only recommended method..." or "The only allowed method...".

Comment for initialized(): " This used during construction." => "This is used during construction."

There is no changelog entry, but I think the scope of changes is small enough to not need one.

After you address those two comments above, the code will be ready to merge, but please do not merge it until #2995 is merged.

comment:5 Changed 7 years ago by stephen

  • Resolution set to fixed
  • Status changed from reviewing to closed

Merged in commit 15471a94d7cd89204b1a7de89398255662590458

Note: See TracTickets for help on using tickets.