Opened 7 years ago

Closed 4 years ago

#3004 closed defect (worksforme)

Cppcheck 1.60.1 and out of bounds access

Reported by: vorner Owned by: tomek
Priority: medium Milestone: Outstanding Tasks
Component: Unclassified Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description (last modified by tomek)

The cppcheck 1.60.1 produces several warnings in form:

src/lib/dhcpsrv/tests/mysql_lease_mgr_unittest.cc:748: check_fail: Array 'leases[2]' accessed at index 2, which is out of bounds. (error,arrayIndexOutOfBounds)

They are all from dhcp code and look like serious programmer error (though they are in the tests).

Subtickets

Change History (6)

comment:1 Changed 7 years ago by shane

  • Milestone changed from New Tasks to DHCP Outstanding Tasks

comment:2 Changed 6 years ago by muks

This may have been fixed already. Please can the DHCP team check it and close the ticket?

(If it's not fixed, the fix should be trivial.)

comment:3 Changed 6 years ago by muks

I looked at these in the new cppcheck report from #3312 and all these seem to be bogus reports.

Can a DHCP developer look and close the ticket?

comment:4 Changed 4 years ago by tomek

  • Milestone changed from DHCP Outstanding Tasks to Outstanding Tasks

Milestone renamed

comment:5 Changed 4 years ago by tomek

  • Description modified (diff)
  • Owner set to tomek
  • Status changed from new to assigned

comment:6 Changed 4 years ago by tomek

  • Resolution set to worksforme
  • Status changed from assigned to closed

The latest cppcheck no longer reports that issue:
https://jenkins.isc.org/job/FreeBSD10.1_32_cpp-check/520/cppcheckResult/

Closing ticket.

Note: See TracTickets for help on using tickets.