Opened 9 years ago

Closed 9 years ago

#297 closed defect (fixed)

msgq test fails if bind10 is running

Reported by: jinmei Owned by: jinmei
Priority: medium Milestone: y2 12 month milestone
Component: ~msgq (obsolete) Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity:
Sub-Project: Feature Depending on Ticket:
Estimated Difficulty: 0.0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

If you run bind10, TestSubscriptionManager.test_open_socket_default of msgq fails:

FAIL: test_open_socket_default (__main__.TestSubscriptionManager)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/jinmei/src/isc/bind10/trunk/src/bin/msgq/tests/msgq_test.py", line 86, in test_open_socket_default
    self.assertFalse(os.path.exists(socket_file))
AssertionError: True is not False

This is not critical, but inconvenient once you regularly start running bind10.

Subtickets

Attachments (1)

msgq-test.diff (1.5 KB) - added by jinmei 9 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 in reply to: ↑ description Changed 9 years ago by jinmei

  • Milestone changed from y2 6 month milestone to y2 12 month milestone

(I encounter this problem every time I try to upgrade BIND 10 on my production server, so I've decided to write a patch:-)

The attached patch will fix the problem. Please review.

Changed 9 years ago by jinmei

comment:2 Changed 9 years ago by jinmei

  • Owner set to UnAssigned
  • Status changed from new to reviewing

comment:3 Changed 9 years ago by jelte

  • Owner changed from UnAssigned to jelte
  • Status changed from reviewing to accepted

comment:4 follow-up: Changed 9 years ago by jelte

  • Owner changed from jelte to jinmei
  • Status changed from accepted to assigned

There's a typo in the comment (distrupted), but apart from that this change is good.

comment:5 in reply to: ↑ 4 Changed 9 years ago by jinmei

  • Resolution set to fixed
  • Status changed from assigned to closed

Replying to jelte:

There's a typo in the comment (distrupted), but apart from that this change is good.

Thanks, merged. Closing.

Note: See TracTickets for help on using tickets.