Opened 7 years ago

Closed 6 years ago

#2939 closed defect (fixed)

check for python sqlite3 module

Reported by: jreed Owned by: jreed
Priority: medium Milestone: Sprint-20131001
Component: build system Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DNS Feature Depending on Ticket:
Estimated Difficulty: 2 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

configure should check for the sqlite3 python module (like it does for setproctitle).

  File "/data/users/tester/git-bind10/bind10/src/bin/loadzone/b10-loadzone", line 24, in <module>
    from isc.datasrc import *
  File "/data/users/tester/git-bind10/bind10/src/lib/python/isc/datasrc/__init__.py", line 33, in <module>
    from isc.datasrc.sqlite3_ds import *
  File "/data/users/tester/git-bind10/bind10/src/lib/python/isc/datasrc/sqlite3_ds.py", line 16, in <module>
    import sqlite3, re, random
  File "/usr/local/lib/python3.2/sqlite3/__init__.py", line 23, in <module>
    from sqlite3.dbapi2 import *
  File "/usr/local/lib/python3.2/sqlite3/dbapi2.py", line 26, in <module>
    from _sqlite3 import *
ImportError: No module named _sqlite3

This happened when python3.2 was installed (without sqlite3 module) while python3.1 and its sqlite3 module was still installed.

Subtickets

Change History (8)

comment:1 Changed 7 years ago by jreed

  • Status changed from new to reviewing

This works for me:

$ cat m4macros/ax_python_sqlite3.m4 
dnl @synopsis AX_PYTHON_SQLITE3
dnl
dnl Test for the Python sqlite3 module used by BIND10's datasource
dnl

AC_DEFUN([AX_PYTHON_SQLITE3], [

# Check for the python sqlite3 module
AC_MSG_CHECKING(for python sqlite3 module)
if "$PYTHON" -c 'import sqlite3' 2>/dev/null ; then
    AC_MSG_RESULT(ok)
else
    AC_MSG_RESULT(missing)
    AC_MSG_ERROR([Missing sqlite3 python module.])
fi

])dnl AX_PYTHON_SQLITE3
--- a/configure.ac
+++ b/configure.ac
@@ -388,7 +388,8 @@ In this case we will continue, but naming of python processe
     fi
 fi
 
-# TODO: check for _sqlite3.py module
+# check for _sqlite3.py module
+AX_PYTHON_SQLITE3

comment:2 Changed 7 years ago by muks

  • Estimated Difficulty changed from 0 to 2

comment:3 Changed 7 years ago by shane

  • Milestone changed from New Tasks to Next-Sprint-Proposed

comment:4 Changed 7 years ago by muks

  • Milestone changed from Next-Sprint-Proposed to Sprint-20130806

Putting to current sprint as we are running out of tickets.

comment:5 Changed 7 years ago by vorner

  • Owner changed from UnAssigned to vorner

comment:6 Changed 7 years ago by vorner

  • Owner changed from vorner to jreed

Hello

It looks mostly OK, just that I didn't find the TODO in the configure.ac, so I picked a place to put it. I put it inside the check for sqlite3 itself. Would you look if that's OK with you? If it is, please merge.

comment:7 Changed 7 years ago by vorner

I forgot to mention ‒ I put it to a branch.

comment:8 Changed 6 years ago by jreed

  • Resolution set to fixed
  • Status changed from reviewing to closed

Thank you. Merged in commit 4e7c1fb3533a53bd6cd21b563553f1e40f9bdf30

No changelog entry needed. Closing this ticket.

Note: See TracTickets for help on using tickets.