Opened 9 years ago

Closed 9 years ago

#290 closed enhancement (fixed)

review: suggestion of minor improvement to datasrc/cache

Reported by: jinmei Owned by: jinmei
Priority: very low Milestone: 06. 4th Incremental Release
Component: data source Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity:
Sub-Project: Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

Please review the attached patch (very small).

It requires knowledge about a bit less common method of std::list, but
should work much faster than erase-then-push_front for moving an entry
to the head of the list (a benchmark indicates it can run 3 times
faster).

Subtickets

Attachments (1)

cache.diff (414 bytes) - added by jinmei 9 years ago.

Download all attachments as: .zip

Change History (5)

Changed 9 years ago by jinmei

comment:1 Changed 9 years ago by jinmei

  • Owner set to UnAssigned
  • Status changed from new to reviewing
  • Type changed from defect to enhancement

comment:2 Changed 9 years ago by jinmei

(I didn't plan to add a changelog entry for this, so didn't include proposed text)

comment:3 Changed 9 years ago by each

  • Owner changed from UnAssigned to jinmei

I haven't used list::splice() before, but based on the doc (and the fact that this presumably passes unit tests), the patch looks fine to me.

comment:4 Changed 9 years ago by jinmei

  • Resolution set to fixed
  • Status changed from reviewing to closed

okay, thanks. committed, closing.

Note: See TracTickets for help on using tickets.