Opened 7 years ago

Closed 7 years ago

#2797 closed enhancement (complete)

Expand EDNS statistics counters for all versions

Reported by: y-aharen Owned by: y-aharen
Priority: medium Milestone: Sprint-20130806
Component: b10-auth Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DNS Feature Depending on Ticket:
Estimated Difficulty: 4 Add Hours to Ticket: 1
Total Hours: 0.32 Internal?: no

Description

Expand EDNS statistics counters to count all versions of
EDNS. It was suggested in the review of #2157.

Subtickets

Change History (7)

comment:1 Changed 7 years ago by y-aharen

  • Milestone changed from New Tasks to Next-Sprint-Proposed

comment:2 Changed 7 years ago by y-aharen

  • Owner set to UnAssigned
  • Status changed from new to reviewing

trac2797 is ready for reviewing.

As discussed in bind10-dev list, I added an explanation to calculate the count of the
requests with EDNS (regardless of version). There is no ChangeLog entry as it is a documentation update.

comment:3 Changed 7 years ago by muks

  • Milestone changed from Next-Sprint-Proposed to Sprint-20130806

Moving to current sprint as we are running out of tickets.

comment:4 Changed 7 years ago by vorner

  • Owner changed from UnAssigned to vorner

comment:5 Changed 7 years ago by vorner

  • Total Hours changed from 0 to 0.32

Hello

The text looks OK.

I noticed one thing: the paragraph (and the one above it) is indented by tabs, not spaces. Could you fix that? That does not need another review, so please merge after that.

As an improvement for future (not in this ticket), it would be nice if the statistics daemon could provide computed values, so it could show the sum, not require the user to take a calculator and sum them manually.

comment:6 Changed 7 years ago by vorner

  • Owner changed from vorner to y-aharen

comment:7 Changed 7 years ago by y-aharen

  • Add Hours to Ticket changed from 0 to 1
  • Resolution set to complete
  • Status changed from reviewing to closed

Hello,

Thank you for reviewing. I expanded tabs in the XML file and merged the branch into master.

Thanks,

Note: See TracTickets for help on using tickets.