Opened 7 years ago

Closed 6 years ago

#2772 closed defect (fixed)

DHCP4: It should be possible to define options having codes 224-254 in the dhcp4 option space.

Reported by: marcin Owned by: marcin
Priority: medium Milestone: Kea0.8
Component: dhcp4 Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: Medium
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

It has been pointed out on the bind10-users mail list: https://lists.isc.org/pipermail/bind10-users/2013-February/000442.html

that it is not possible to define option having code 252 in the dhcp4 option space. This appears to be a bug in the code because this code belongs to the pool of option codes reserved for private use (see http://www.iana.org/assignments/bootp-dhcp-parameters/bootp-dhcp-parameters.xml).

In the closer look into the code it appears that this pool is by mistake excluded when checking for options in dhcp4 option space which definitions can be defined by a user (see src/lib/dhcp/libdhcp++.cc, function LibDHCP::isStandardOption).

Subtickets

Change History (7)

comment:1 Changed 6 years ago by marcin

This ticket has a duplicate: #3219

comment:2 Changed 6 years ago by marcin

  • Milestone changed from DHCP Outstanding Tasks to DHCP-Kea1.0-alpha

comment:3 Changed 6 years ago by marcin

  • Owner set to marcin
  • Status changed from new to assigned

comment:4 Changed 6 years ago by marcin

  • Owner changed from marcin to UnAssigned
  • Status changed from assigned to reviewing

The range of Private Options is now excluded from the standard options set. Proposed changelog entry:

XXX.	[bug]		marcin
	libdhcp++: Fixed the bug whereby DHCPv4 options with codes 224-254 were
	treated as standard options.
	(Trac #2772, git abc)

comment:5 Changed 6 years ago by tmark

  • Owner changed from UnAssigned to tmark

comment:6 Changed 6 years ago by tmark

  • Owner changed from tmark to marcin

You may want to extend the ChangeLog? entry a little:

Fixed the bug which incorrectly treated DHCPv4 option codes 224-254 as standard options, barring them from being used as custom options.

Other than that, the changes are fine. I used the original bug reporter's configuration commands to verify both that the bug existed and that this change corrects it.

Please merge.

comment:7 Changed 6 years ago by marcin

  • Resolution set to fixed
  • Status changed from reviewing to closed

Merged with commit c6158690c389d75686545459618ae0bf16f2cdb8

Note: See TracTickets for help on using tickets.