Opened 7 years ago

Closed 6 years ago

#2756 closed enhancement (fixed)

AUTH_DATASRC_CLIENTS_BUILDER_RECONFIGURE_ERROR should name the datasource

Reported by: cas Owned by: muks
Priority: high Milestone: bind10-1.2-release-freeze
Component: b10-auth Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DNS Feature Depending on Ticket:
Estimated Difficulty: 2 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

the error message AUTH_DATASRC_CLIENTS_BUILDER_RECONFIGURE_ERROR should contain the context needed to fix the error, namely the datasource configuration that causes this error:

2013-02-15 13:38:21.293 ERROR [b10-auth.auth/3470] AUTH_DATASRC_CLIENTS_BUILDER_RECONFIGURE_ERROR Internal error setting up data source: Auto-detection of zones to cache is not yet implemented, supply cache-zones parameter

Subtickets

Change History (10)

comment:1 Changed 7 years ago by vorner

Such actual error should have been somewhere above it. But I'm not against repeating the name here.

comment:2 Changed 7 years ago by jinmei

in general, the ClientList? could log more things. I suspect this is one of the things.
in this specific case it's a result of exception, so it could also give more details
in the what() message.

comment:3 Changed 7 years ago by shane

  • Milestone changed from New Tasks to Next-Sprint-Proposed
  • Type changed from defect to enhancement

Seems like a simple, useful change. Putting on next-sprint-proposed.

comment:4 Changed 7 years ago by shane

  • Milestone changed from Previous-Sprint-Proposed to Next-Sprint-Proposed

comment:5 Changed 7 years ago by shane

  • Priority changed from medium to high

comment:6 Changed 6 years ago by muks

  • Milestone set to Sprint-20131015
  • Owner set to UnAssigned
  • Status changed from new to reviewing

Up for review.

comment:7 Changed 6 years ago by pselkirk

  • Owner changed from UnAssigned to muks

The changes look sane, but I don't see them in the unittest output. Are there tests that triggers these messages?

comment:8 Changed 6 years ago by muks

  • Owner changed from muks to pselkirk

The branch updates an exception message .what() that is actually user-visible as part of a log message. We don't check for exception messages or log messages at all in the unittests. We test for exception types thrown (like isc::InvalidParameter) in unittests and log message IDs (like AUTH_DATASRC_CLIENTS_BUILDER_RECONFIGURE_ERROR) in the lettuce tests. These remain the same.

comment:9 Changed 6 years ago by pselkirk

  • Owner changed from pselkirk to muks

Okay to merge then.

comment:10 Changed 6 years ago by muks

  • Resolution set to fixed
  • Status changed from reviewing to closed

Merged to master branch in commit 31872754f36c840b4ec0b412a86afe9f38be86e0:

* 7bfadaf [2756] Include the datasource config that's causing an error

Resolving as closed. Thank you for the reviews Paul.

Note: See TracTickets for help on using tickets.