Opened 7 years ago

Closed 7 years ago

#2747 closed defect (fixed)

left over .pyo files

Reported by: jreed Owned by: UnAssigned
Priority: low Milestone:
Component: build system Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: Low
Sub-Project: Core Feature Depending on Ticket:
Estimated Difficulty: 3 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

See my old https://lists.isc.org/pipermail/bind10-changes/2012-March/009139.html
that is my commit a8486dda670bf22c27c7cb2ee95b84cc53c1fc08

I saw the similar problem today with python 3.1.2.
http://git.bind10.isc.org/~tester/builder/BIND10-distcheck/20130215010523-FreeBSD8-i386/logs/distcheck.out

ERROR: files left in build directory after distclean:
./src/lib/python/isc/log_messages/work/pycc_messages.pyo

The workaround (untested) is probably:

diff --git a/src/lib/python/isc/cc/Makefile.am b/src/lib/python/isc/cc/Makefile.am
index f7c5b00..fe7d747 100644
--- a/src/lib/python/isc/cc/Makefile.am
+++ b/src/lib/python/isc/cc/Makefile.am
@@ -7,6 +7,7 @@ pylogmessagedir = $(pyexecdir)/isc/log_messages/
 
 CLEANFILES = $(PYTHON_LOGMSGPKG_DIR)/work/pycc_messages.py
 CLEANFILES += $(PYTHON_LOGMSGPKG_DIR)/work/pycc_messages.pyc
+CLEANFILES += $(PYTHON_LOGMSGPKG_DIR)/work/pycc_messages.pyo
 
 EXTRA_DIST = pycc_messages.mes proto_defs.py

But we have many other CLEANFILES like the same without the .pyo.

This ticket is to investigate why they are left around and to fix it.

Subtickets

Change History (2)

comment:1 Changed 7 years ago by jwright

  • Component changed from Unclassified to build system
  • Defect Severity changed from N/A to Low
  • Milestone New Tasks deleted
  • Owner set to UnAssigned
  • Priority changed from medium to low

comment:2 Changed 7 years ago by jreed

  • Resolution set to fixed
  • Status changed from new to closed

da42298dc1ad39a5073bb8b221e05ccf8fb5464c is commit for this.

I decide to just close this ticket now. I assume that we had no test that caused the .pyo to be generated before so was not needed before.

Note: See TracTickets for help on using tickets.