Opened 9 years ago

Closed 9 years ago

#269 closed defect (fixed)

loadzone: improve the output accuracy for 7 RR(s) loaded in 0 second(s) problem

Reported by: shentingting Owned by: shentingting
Priority: low Milestone:
Component: Unclassified Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity:
Sub-Project: Feature Depending on Ticket:
Estimated Difficulty: 0.0 Add Hours to Ticket:
Total Hours: Internal?: no

Description

when zone file includes few RRS, The output time is less 1s. So The verbose status includes "7 RR(s) loaded in 0 second(s)", This is wrong!

Subtickets

Attachments (1)

diff.master (570 bytes) - added by shentingting 9 years ago.

Download all attachments as: .zip

Change History (6)

Changed 9 years ago by shentingting

comment:1 Changed 9 years ago by shentingting

This fix it:

Index: master.py
===================================================================
--- master.py (版本 2387)
+++ master.py (工作副本)
@@ -228,7 +228,7 @@

percent = (self.cur * 100)/self.filesize


sys.stdout.write("\r" + (80 * " "))

  • sys.stdout.write("\r%d RR(s) loaded in %d second(s) (%.2f%% of %s%s)"\

+ sys.stdout.write("\r%d RR(s) loaded in %.2f second(s) (%.2f%% of %s%s)"\

% (MasterFile?.records_num, interval, percent, MasterFile?.file_type, self.datafile))


def del(self):

comment:2 follow-up: Changed 9 years ago by zhanglikun

Tingting, please change your os language to English.

comment:3 Changed 9 years ago by zhanglikun

Tingting, I have reviewed this patch, please commit to trunk.

comment:4 in reply to: ↑ 2 Changed 9 years ago by jinmei

Replying to zhanglikun:

Tingting, please change your os language to English.

Oh, I (personally) don't mind seeing non alphabet characters in such harmless places as this one (as long as they are encoded in an generally interoperable way, i.e., in utf-8 in practice).

comment:5 Changed 9 years ago by zhanglikun

  • billable set to 0
  • Estimated Difficulty set to 0.0
  • Internal? unset
  • Resolution set to fixed
  • Status changed from new to closed

The patch had been committed to trunk, so close this one.

Note: See TracTickets for help on using tickets.