Opened 7 years ago

Closed 5 years ago

#2674 closed defect (wontfix)

Use data types consistently in isc::cc::Session

Reported by: vorner Owned by:
Priority: low Milestone: Remaining BIND10 tickets
Component: ~Inter-module communication(obsolete) Version: bind10-old
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: Low
Sub-Project: Core Feature Depending on Ticket:
Estimated Difficulty: 3 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

The Session uses some binary integers in the wire protocol. However, it mixes the types on read and write, sometimes using size_t, sometimes uint32_t and sometimes unsigned int. The other length is sometimes uint16_t and sometimes unsigned short.

The python counterpart consistently uses the U and H modifiers to read and write them, so uint32_t and uint16_t should be used consistently in the C++ part too. Currently, it works mostly because of luck.

Subtickets

Change History (4)

comment:1 Changed 7 years ago by jwright

  • Defect Severity changed from N/A to Low
  • Milestone New Tasks deleted
  • Priority changed from medium to low

comment:2 Changed 7 years ago by vorner

Also, the return type of group_sendmsg is int, but long int is used inside (and in the protocol). The same for the parameter of group_recvmsg. This needs to be modified in the session code, but also in code calling it.

comment:3 Changed 6 years ago by tomek

  • Milestone set to Remaining BIND10 tickets

comment:4 Changed 5 years ago by tomek

  • Resolution set to wontfix
  • Status changed from new to closed
  • Version set to old-bind10

This issue is related to bind10 code that is no longer part of Kea.

If you are interested in BIND10/Bundy framework or its DNS components,
please check http://bundy-dns.de.

Closing ticket.

Note: See TracTickets for help on using tickets.