Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#2644 closed defect (fixed)

python3.3 and notify_out_test.py failure

Reported by: muks Owned by: muks
Priority: medium Milestone: Sprint-20130205
Component: tests Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DNS Feature Depending on Ticket:
Estimated Difficulty: 1 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

Using python 3.3.0:

Running test: notify_out_test.py
.....F..............
======================================================================
FAIL: test_prepare_select_info (__main__.TestNotifyOut)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/muks/bind10/src/lib/python/isc/notify/tests/notify_out_test.py", line 439, in test_prepare_select_info
    self.assertListEqual([2, 1], valid_fds)
AssertionError: Lists differ: [2, 1] != [1, 2]

First differing element 0:
2
1

- [2, 1]
+ [1, 2]

----------------------------------------------------------------------
Ran 20 tests in 0.114s

FAILED (failures=1)

Subtickets

Attachments (1)

0003-2644-Fix-test-failures-in-notify_out_test.py-under-P.patch (1.1 KB) - added by muks 7 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 7 years ago by muks

I have got a patch for this and will attach it shortly. I have upgraded to Fedora 18 over this weekend, which has Python 3.3.

comment:2 follow-up: Changed 7 years ago by vorner

It should also check there's nothing extra in the list.

comment:3 Changed 7 years ago by jelte

  • Milestone changed from Next-Sprint-Proposed to Sprint-20130205

comment:4 in reply to: ↑ 2 Changed 7 years ago by muks

  • Owner changed from muks to UnAssigned
  • Status changed from new to reviewing

Replying to vorner:

It should also check there's nothing extra in the list.

It does that by checking the length of the list first.

This is ready for review.

comment:5 Changed 7 years ago by jelte

  • Owner changed from UnAssigned to muks

this one is ok too

comment:6 Changed 7 years ago by muks

  • Resolution set to fixed
  • Status changed from reviewing to closed

Merged to master branch in commit 3d4f3cd903294e03bafbf37963051fdcf2233cae:

* ea78072 [2644] Fix test failures in notify_out_test.py under Python 3.3

Resolving as fixed. Thank you for the review Jelte.

comment:7 Changed 7 years ago by muks

  • Estimated Difficulty changed from 0 to 1

Add estimate from sprint meeting log.

Note: See TracTickets for help on using tickets.