Opened 7 years ago

Closed 7 years ago

#2623 closed defect (fixed)

python3.3 and msgq_test.py

Reported by: jreed Owned by: muks
Priority: medium Milestone: Sprint-20130205
Component: tests Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: Core Feature Depending on Ticket:
Estimated Difficulty: 2 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

Using python 3.3.0:

Running test: msgq_test.py
...EE............
======================================================================
ERROR: test_send_raise_nonrecoverable (__main__.SendNonblock)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/b10builder/builder/work/BIND10-valgrind/20130110133225-CentOS5-x86_64-GCC/build/src/bin/msgq/tests/msgq_test.py", line 442, in test_send_raise_nonrecoverable
    sockerr.errno = err
TypeError: can't set attributes of built-in/extension type 'OSError'

======================================================================
ERROR: test_send_raise_recoverable (__main__.SendNonblock)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/b10builder/builder/work/BIND10-valgrind/20130110133225-CentOS5-x86_64-GCC/build/src/bin/msgq/tests/msgq_test.py", line 429, in test_send_raise_recoverable
    sockerr.errno = err
TypeError: can't set attributes of built-in/extension type 'OSError'

----------------------------------------------------------------------
Ran 17 tests in 1.237s

FAILED (errors=2)
make[6]: *** [check-local] Error 1
make[6]: Leaving directory `/home/b10builder/builder/work/BIND10-valgrind/20130110133225-CentOS5-x86_64-GCC/build/src/bin/msgq/tests'

Subtickets

Attachments (1)

0001-2623-Fix-test-failures-in-msgq_test.py-under-Python-.patch (1.5 KB) - added by muks 7 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 7 years ago by jwright

  • Component changed from msgq to tests
  • Milestone changed from New Tasks to Next-Sprint-Proposed

comment:2 Changed 7 years ago by muks

  • Owner set to muks
  • Status changed from new to assigned

I have got a patch for this and will attach it shortly. I have upgraded to Fedora 18 over this weekend, which has Python 3.3.

comment:3 Changed 7 years ago by jelte

  • Milestone changed from Next-Sprint-Proposed to Sprint-20130205

comment:4 Changed 7 years ago by muks

  • Owner changed from muks to UnAssigned
  • Status changed from assigned to reviewing

This is ready for review.

comment:5 Changed 7 years ago by jelte

  • Owner changed from UnAssigned to muks

this one looks fine too

comment:6 Changed 7 years ago by muks

  • Resolution set to fixed
  • Status changed from reviewing to closed

Merged to master branch in commit 443be4318110331b2761b8d945dab4f05d765a1a:

* 8a33bc3 [2623] Fix test failures in msgq_test.py under Python 3.3

Resolving as fixed. Thank you for the review Jelte.

Note: See TracTickets for help on using tickets.