Opened 7 years ago

Closed 7 years ago

#2619 closed defect (fixed)

getFullConfig() does not do what you'd think it does

Reported by: jelte Owned by: jelte
Priority: medium Milestone: Sprint-DHCP-20130122
Component: Unclassified Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DNS Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

The doxygen explains what it does, but this is really not how we use it (or what the name suggests). I think that every place that uses it uses it wrong, but it happens to work because of the specific data structures used.

So this ticket is to change its behaviour not to make a list of item->value pairs but simply go over the top-level items and to do getValue(). This may not fill in some deep defaults but those tend to be separately checked anyway (since updates also don't include them)

Subtickets

Change History (3)

comment:1 Changed 7 years ago by jelte

  • Milestone changed from New Tasks to Sprint-DHCP-20130122
  • Owner set to stephen
  • Status changed from new to reviewing

comment:2 Changed 7 years ago by stephen

  • Owner changed from stephen to jelte

Reviewed commit 397592d08bdf50867607aac57cae5aef6ccf9c61

That does the trick, thanks.

The code can be merged. However, this ticket has been branched from #2559. To keep things clear (plus the fact that #2559 is not yet complete), I'd suggest merging these changes separately to master. I need to merge master into #2559 anyway to pick up some other changes, so will be able to use this modification in further development and testing.

I would also suggest that this alteration needs a ChangeLog entry - perhaps something like:

NNN.	[func]		jelte
	When sending a full configuration to BIND 10 modules, the configuration is now
	set as properly-structured JSON.  Previously, the structure had been flattened,
	with all data being labelled by fully-qualified element names.
	(Trac #2619, git xxx)

comment:3 Changed 7 years ago by jelte

  • Resolution set to fixed
  • Status changed from reviewing to closed

merged and pushed, closing ticket

Note: See TracTickets for help on using tickets.