Opened 7 years ago

Closed 7 years ago

#2593 closed defect (fixed)

Using old versions of boost::optional fails with GCC 4.4.x and above

Reported by: muks Owned by: muks
Priority: medium Milestone: Sprint-20130122
Component: libdns++ Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DNS Feature Depending on Ticket:
Estimated Difficulty: 4 Add Hours to Ticket: 0
Total Hours: 0.34 Internal?: no

Description

Using old versions of boost::optional fails with GCC 4.4.x and above. This was discovered on our Debian i686 builder. Please see the discussion here:
https://lists.isc.org/pipermail/bind10-dev/2012-December/004189.html
https://lists.isc.org/pipermail/bind10-dev/2013-January/004191.html

We have to detect it, or require a new version of boost when configure runs.

Subtickets

Change History (7)

comment:1 Changed 7 years ago by jelte

  • Milestone changed from Next-Sprint-Proposed to Sprint-20130122

comment:2 Changed 7 years ago by muks

  • Owner changed from UnAssigned to muks
  • Status changed from new to assigned

Picking

comment:3 Changed 7 years ago by muks

  • Owner changed from muks to UnAssigned
  • Status changed from assigned to reviewing

Up for review. This uses the workaround approach.

Does this require a ChangeLog entry? It fixes an issue that we introduced before any subsequent releases have been made, and no changes to build dependencies are necessary.

comment:4 Changed 7 years ago by muks

BTW, I have tested the workaround on Fedora 17 x86_64 and the Debian i686 buildbot and they both pass.

comment:5 Changed 7 years ago by vorner

  • Owner UnAssigned deleted

comment:6 Changed 7 years ago by vorner

  • Owner set to muks
  • Total Hours changed from 0 to 0.34

Hello

It seems OK. Please merge.

comment:7 Changed 7 years ago by muks

  • Resolution set to fixed
  • Status changed from reviewing to closed

Merged to master branch in commit b6d00d5fb3657b555c9f25d4c23721d277a7d7a4:

* d86e308 [2593] Workaround the aliasing problem in boost::optional

Resolving as fixed. Thank you for the review Michal.

Note: See TracTickets for help on using tickets.