Opened 7 years ago

Closed 4 years ago

#2552 closed defect (invalid)

log output has two spaces after INFO

Reported by: jreed Owned by:
Priority: low Milestone: Remaining BIND10 tickets
Component: logging Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: Low
Sub-Project: Core Feature Depending on Ticket:
Estimated Difficulty: 2 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

On some systems I see two spaces after INFO for log messages.
So I can't parse by splitting on single space.

On two different platforms using log to file.
using log4cplus-1.0.4 and log4cplus-1.1.0

Subtickets

Change History (6)

comment:1 Changed 7 years ago by jinmei

Can you show specific examples?

comment:2 Changed 7 years ago by jelte

FYI, it's not just INFO, we currently use this pattern:

string pattern = "%D{%Y-%m-%d %H:%M:%S.%q} %-5p [%c/%i] %m\n";

The loglevel is the %-5p entry; i.e. pad with spaces if loglevel is less than 5 characters.

I guess this is done so the logger name is always aligned nicely (and in exactly the same column).

Is an easy split on a single space more important? Then it's trivial to change, but we may need to update a couple of tests.

comment:3 Changed 7 years ago by jwright

We should decide as a group what is more important: visual cleanliness of output, or ease of parsing. Seems to me that changing the parser to split on whitespace (instead of single space) should be easy enough, but we need to discuss.

comment:4 Changed 7 years ago by shane

  • Milestone New Tasks deleted

comment:5 Changed 6 years ago by tomek

  • Milestone set to Remaining BIND10 tickets

comment:6 Changed 4 years ago by tomek

  • Resolution set to invalid
  • Status changed from new to closed

We did review a number of tickets as part of bug scrubbing during Kea 1.0 timeframe and decided that some of them are no longer useful. For reasoning, see spreadsheet in mail discussion called bug-scrubbing.

Note: See TracTickets for help on using tickets.