Opened 7 years ago

Closed 6 years ago

#2517 closed defect (fixed)

RRSIG wire tests don't check rendered data

Reported by: muks Owned by: muks
Priority: medium Milestone: bind10-1.2-release-freeze
Component: libdns++ Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: Low
Sub-Project: DNS Feature Depending on Ticket:
Estimated Difficulty: 3 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

RRSIG unittests in Rdata_RRSIG_Test.toWireRenderer and Rdata_RRSIG_Test.toWireBuffer don't check anything. They should check the output after calling toWire().

Subtickets

Change History (6)

comment:1 Changed 7 years ago by jwright

  • Defect Severity changed from N/A to Low
  • Milestone New Tasks deleted

comment:2 Changed 6 years ago by muks

  • Milestone set to Sprint-20131015
  • Status changed from new to reviewing

Up for review.

comment:3 Changed 6 years ago by muks

No ChangeLog entry is necessary.

comment:4 Changed 6 years ago by kean

  • Owner changed from UnAssigned to kean

comment:5 Changed 6 years ago by kean

  • Owner changed from kean to muks

This looks just fine and you can go ahead and merge and close.

comment:6 Changed 6 years ago by muks

  • Resolution set to fixed
  • Status changed from reviewing to closed

Merged to master branch in commit 06b32bac47c7571281fa9bbcd88017c1b3fd0e48:

* 96bb3a8 [2517] Add tests for RRSIG toWire() methods

Resolving as fixed. Thank you for the review Kean.

Note: See TracTickets for help on using tickets.