Opened 9 years ago

Closed 9 years ago

#251 closed enhancement (fixed)

support SunStudio C++ compiler

Reported by: jinmei Owned by: jinmei
Priority: medium Milestone: 05. 3rd Incremental Release: Serious Secondary
Component: build system Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity:
Sub-Project: Feature Depending on Ticket:
Estimated Difficulty: Add Hours to Ticket:
Total Hours: Internal?:

Description

We need some non trivial protable fixes for SunStudio?.

Subtickets

Change History (5)

comment:1 Changed 9 years ago by jinmei

branches/trac251 is ready for review.

The diff can be retrieved by:
svn diff -r 2226 svn+ssh://bind10.isc.org/svn/bind10/branches/trac251

This is mostly a build portability fix. The only non trivial point is the change to some operator-> implementation, which requires C++ knowledge:

-        return (it_.operator->());
+        return (&(operator*()));
...
-    return (impl_->it_.operator->());
+    return (&(operator*()));

The new code does essentially the same thing, just in a more portable way.

comment:2 Changed 9 years ago by jinmei

Oh, forgot to say this: I think we can skip gtest support for now.

And this is the proposed ChangeLog entry:

  59.	[build]		jinmei
	Supported SunStudio C++ compiler.  Note: gtest still doesn't work.
	(Trac #251, svn rTBD)

comment:3 Changed 9 years ago by jinmei

  • Owner changed from jinmei to UnAssigned
  • Status changed from new to reviewing

comment:4 follow-up: Changed 9 years ago by shane

  • Owner changed from UnAssigned to jinmei

I had a look at the changes, and they look fine (although I don't have a Sun compiler to test them with). Please merge!

comment:5 in reply to: ↑ 4 Changed 9 years ago by jinmei

  • Resolution set to fixed
  • Status changed from reviewing to closed

Replying to shane:

I had a look at the changes, and they look fine (although I don't have a Sun compiler to test them with). Please merge!

Thanks, merge done (r2310). Closing.

Note: See TracTickets for help on using tickets.