Opened 7 years ago

Closed 7 years ago

#2481 closed defect (fixed)

gtest should run in distcheck --with-gtest

Reported by: jinmei Owned by: jreed
Priority: medium Milestone:
Component: build system Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: Core Feature Depending on Ticket:
Estimated Difficulty: 2 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

I just realized distcheck doesn't build/run gtest if we specify
--with-gtest (not --with-gtest-source). It's a clear regression
from the previous behavior and should be corrected.

Subtickets

Change History (4)

comment:1 Changed 7 years ago by jreed

There is a TODO about it in the configure.ac:

# TODO: set DISTCHECK_GTEST_CONFIGURE_FLAG for --with-gtest too

For the automated builder I do:

DISTCHECK_CONFIGURE_FLAGS="--disable-install-configurations --with-gtest"
make distcheck DISTCHECK_CONFIGURE_FLAGS="${DISTCHECK_CONFIGURE_FLAGS}"

comment:2 Changed 7 years ago by jreed

  • Owner changed from UnAssigned to jreed
  • Status changed from new to assigned

comment:3 Changed 7 years ago by jreed

This appears to fix it.

diff --git a/configure.ac b/configure.ac
index feeb9a9..87b2803 100644
--- a/configure.ac
+++ b/configure.ac
@@ -903,11 +903,12 @@ AC_SUBST(MULTITHREADING_FLAG)
 #
 GTEST_LDFLAGS=
 GTEST_LDADD=
-# TODO: set DISTCHECK_GTEST_CONFIGURE_FLAG for --with-gtest too
 DISTCHECK_GTEST_CONFIGURE_FLAG=
 
 if test "x$enable_gtest" = "xyes" ; then
 
+    DISTCHECK_GTEST_CONFIGURE_FLAG="--with-gtest=$gtest_path"
+
     if test -n "$with_gtest_source" ; then
 
           if test "x$GTEST_SOURCE" = "xyes" ; then

comment:4 Changed 7 years ago by jreed

  • Resolution set to fixed
  • Status changed from assigned to closed

fixed with 172e704b668189d6057c4bfc80403edd59aadd5c

reviewed via jabber.

No changelog entry.

Note: See TracTickets for help on using tickets.