Opened 7 years ago

Closed 7 years ago

#2463 closed defect (fixed)

DHCPv6 Config Parser: default values are cleared on subsequent configuration attempts.

Reported by: marcin Owned by: marcin
Priority: medium Milestone: Sprint-DHCP-20121115
Component: ~dhcpconf(obsolete) Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: High
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

When configuring DHCPv6 server with bindctl the default subnet parameter values are cleared and subsequent configuration attempts fail due to lack of thereof. Default/global configuration parameters should be rather replaced when necessary not removed from storages. The following code lines in config_parser.cc (line 1120) are culprit:

    option_defaults.clear();
    uint32_defaults.clear();
    string_defaults.clear();

Subtickets

Change History (4)

comment:1 Changed 7 years ago by marcin

  • Owner changed from marcin to UnAssigned
  • Status changed from new to reviewing

The global values are preserved after config commit. When new configuration request comes, old global values (if exist) are replaced with new values or new values are added if nothing exists in a storage.
Each unit test now clears the configuration database by issuing the configuration string which sets subnets list and option list empty. It also sets uint32 values to defaults. This prevents affecting test result by configuration left by a previous test.

The issue that has been left unresolved for now is #2469.

Please review.

comment:2 Changed 7 years ago by sar

I've reviewed the changes and everything seems fine.

I've sent a list of minor typos via email. Incorporating them may make the comments a bit clearer but none of them are major.

As I'm not sure yet which commit number to include, the ones I reviewed were
8fd47c03a3100c41e34181b95465aa98a77538d1
43d61adcf5a876a3a5c76ba78ea4c980d7e70704
248da8cb1f68c93e411d3b1b22479acaaa255c15
2a9fd6c61e6b9c3d5c8bc2dba64f4196a2bf953f
03e57865c07485b2e8165ae353207c2c6400297c

comment:3 Changed 7 years ago by sar

  • Owner changed from UnAssigned to marcin

comment:4 Changed 7 years ago by marcin

  • Resolution set to fixed
  • Status changed from reviewing to closed

Typos fixed and merged to master.

Note: See TracTickets for help on using tickets.