Opened 9 years ago

Closed 9 years ago

#242 closed defect (fixed)

remote_config functions aren't fully cleaned up in CCSession

Reported by: jelte Owned by: jelte
Priority: low Milestone: 05. 3rd Incremental Release: Serious Secondary
Component: configuration Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity:
Sub-Project: Feature Depending on Ticket:
Estimated Difficulty: Add Hours to Ticket:
Total Hours: Internal?:

Description (last modified by shane)

There's an unsubscribe missing in remove_remote_config(), and possibly we need a destructor that does that for all registered remote configurations.

This should be a pretty easy change.

Subtickets

Attachments (2)

bind10_trac242.patch (4.5 KB) - added by jelte 9 years ago.
bind10_trac242_2.patch (5.4 KB) - added by jelte 9 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 9 years ago by shane

  • Component changed from Unclassified to configuration
  • Description modified (diff)

comment:2 Changed 9 years ago by jelte

  • Status changed from new to accepted

Things needed to be done:

  • unsubscribe to the remote module's command channel when remove_remote_config() is called
  • unsubscribe to all when the object is destroyed

I also fixed a hardcoded name that had lingered and replaced it with COMMAND_GET_CONFIG

Attaching diff (seemed too small to branch for)

Changed 9 years ago by jelte

comment:3 Changed 9 years ago by jelte

  • Owner changed from jelte to UnAssigned
  • Status changed from accepted to reviewing

comment:4 Changed 9 years ago by shane

  • Owner changed from UnAssigned to shane
  • Status changed from reviewing to accepted

comment:5 Changed 9 years ago by shane

  • Owner changed from shane to jelte
  • Status changed from accepted to assigned

I notice that we group_subscribe() to self._module_name but don't unsubscribe from it in the destructor (since it is not in the _remote_module_config variable). Should we do that?

Changed 9 years ago by jelte

comment:6 Changed 9 years ago by jelte

  • Owner changed from jelte to shane

You are right, updated the patch, add unsubscribe to destructor and added a check in the test to see if it happened.

comment:7 Changed 9 years ago by shane

  • Owner changed from shane to jelte

Okay, looks good for merge.

comment:8 Changed 9 years ago by jelte

  • Resolution set to fixed
  • Status changed from assigned to closed

Merged in r2369, closing ticket.

Note: See TracTickets for help on using tickets.