Opened 7 years ago

Closed 4 years ago

#2419 closed defect (worksforme)

ConfigData::getFullConfig() should return child elements content

Reported by: tomek Owned by: UnAssigned
Priority: medium Milestone: Remaining BIND10 tickets
Component: configuration Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: Core Feature Depending on Ticket:
Estimated Difficulty: 7 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

ConfigData::getFullConfig() currently returns only list of elements on top level, but it should return all child elements as well. This will likely be trivial to implement as stringValue() -> str() change.

Subtickets

Change History (10)

comment:1 Changed 7 years ago by tomek

  • Status changed from new to accepted

comment:2 Changed 7 years ago by tomek

  • Owner changed from tomek to UnAssigned
  • Status changed from accepted to assigned

Config as seen from bindctl:

> config show Dhcp6
Dhcp6/interface/	list	(default)
Dhcp6/renew-timer	1001	integer	
Dhcp6/rebind-timer	2000	integer	(default)
Dhcp6/preferred-lifetime	3000	integer	(default)
Dhcp6/valid-lifetime	4000	integer	(default)
Dhcp6/option-data	[]	list	(default)
Dhcp6/subnet6/	list	
> config show Dhcp6/subnet6[0]
Dhcp6/subnet6[0]/subnet	"2001:db8:1::/64"	string	
Dhcp6/subnet6[0]/renew-timer	1000	integer	(default)
Dhcp6/subnet6[0]/rebind-timer	2000	integer	(default)
Dhcp6/subnet6[0]/preferred-lifetime	3000	integer	(default)
Dhcp6/subnet6[0]/valid-lifetime	7200	integer	(default)
Dhcp6/subnet6[0]/pool/	list	
Dhcp6/subnet6[0]/option-data	[]	list	(default)
> config show Dhcp6/subnet6[0]/pool[0]
Dhcp6/subnet6[0]/pool[0]	"2001:db8:1::0 - 2001:db8:1::ffff"	string	

Config as returned by getFullConfig():

2012-11-03 23:16:03.391 DEBUG [b10-dhcp6.dhcp6] DHCP6_CONFIG_START DHCPv6 server is processing the following configuration: { "interface": [ "all" ], "option-data": [  ], "preferred-lifetime": 3000, "rebind-timer": 2000, "renew-timer": 1000, "subnet6": [  ], "valid-lifetime": 4000 }

Note that subnet6 actually has some content, but getFullConfig() shows it as being empty.

Useful code point to start debugging:
configureDhcp6Server() call in ControlledDhcpv6Srv::establishSession() in src/bin/dhcp6/ctrl_dhcp6_srv.cc.

comment:3 Changed 7 years ago by stephen

  • Milestone changed from Sprint-DHCP-20121115 to DHCP 2012

comment:4 Changed 7 years ago by stephen

  • Milestone changed from DHCP Outstanding Tasks to New Tasks

comment:5 Changed 7 years ago by vorner

I believe this is the desired behaviour of config show, that we have config showall for the DFS version through the whole config.

Is it really the function at fault, or is it that the bindctl shows only that part?

comment:6 Changed 7 years ago by jinmei

as usual, I think we should consider these types of issues at a higher
level, i.e, how the entire config API should look like. I'm afraid
just tweaking one existing API for one particular purpose will simply
make it messier.

comment:7 Changed 7 years ago by muks

  • Estimated Difficulty changed from 0 to 7

comment:8 Changed 7 years ago by shane

  • Milestone New Tasks deleted

comment:9 Changed 6 years ago by tomek

  • Milestone set to Remaining BIND10 tickets

comment:10 Changed 4 years ago by tomek

  • Resolution set to worksforme
  • Status changed from assigned to closed
  • Version set to git

No longer revelant. We fixed this class of issues by removing bind10 framework.

Note: See TracTickets for help on using tickets.