Opened 7 years ago

Closed 7 years ago

#2416 closed defect (fixed)

lettuce fails in DDNS System / module tests

Reported by: muks Owned by: muks
Priority: medium Milestone: Sprint-20121106
Component: Unclassified Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DNS Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Subtickets

Attachments (1)

0001-master-Wait-for-AUTH_LOAD_ZONE-in-lettuce-test.patch (827 bytes) - added by muks 7 years ago.
Patch to fix this issue

Download all attachments as: .zip

Change History (5)

Changed 7 years ago by muks

Patch to fix this issue

comment:1 Changed 7 years ago by muks

  • Owner changed from muks to UnAssigned
  • Status changed from new to reviewing

Lettuce (instead of waiting for a new AUTH_LOAD_ZONE message) waits for the last output AUTH_LOAD_ZONE message for the SOA=1239 case because the last SOA=1238 case generated a AUTH_LOAD_ZONE that was not skipped past in RunningProcess._wait_for_output_str(). So it immediately matches the last AUTH_LOAD_ZONE and continues right away which causes it to query Auth prematurely.

The fix is simple as in the patch.

Version 0, edited 7 years ago by muks (next)

comment:2 Changed 7 years ago by jelte

note that that log message identifier will change when #2213 is merged, so this fix might need a little tweak by then.

comment:3 Changed 7 years ago by jelte

  • Owner changed from UnAssigned to muks

ok, this appears to work, please merge (ignore my previous comment, I have not merged #2213 yet, and I'll update this when I do)

comment:4 Changed 7 years ago by muks

  • Resolution set to fixed
  • Status changed from reviewing to closed

Pushed to master branch in commit 9a15250b2c74f8b637cf1f32f79cc626cb05d0e5:

* 9a15250 [2416] Wait for AUTH_LOAD_ZONE in lettuce test

Resolving as fixed. Thank you for the review Jelte.

Note: See TracTickets for help on using tickets.