Opened 7 years ago

Closed 6 years ago

#2395 closed defect (wontfix)

introduce a simpler way of using faked data source from auth tests

Reported by: jinmei Owned by:
Priority: medium Milestone: DNS Outstanding Tasks
Component: b10-auth Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DNS Feature Depending on Ticket:
Estimated Difficulty: 7 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

Some of the current tests in auth_srv_unittest tweaks existing
data source clients by bruteforcing its contents (using the
getDataSources() interface and directly rewrites the internal).
IMO it relies too much on the internal of data source clients and
makes both the class and tests fragile. For tests of client-list
itself it might be considered a necessary evil, but for tests of their
users I think it goes too far.

This also one major reason we currently need (in #2211, hopefully soon
in master) the swapDataSrcClientLists, which also makes the
DataSrcClientsMgr integrity weaker. It's also the reason why we
need to return a shared pointer from
DataSrcClientsMgr::Holder.findClientList() (because this test
internally destroys the original due to the brutteforce replacement)
even though it could return a bare pointer based on its nature.

What we actually need is, IMO, a cleaner way for tests like
AuthSrvTest to use some faked data source clients (e.. one that
throws on findZone(), instead of relying on the low level internal
details of the client list implementation.

This task is to design such a way and implement it.

Subtickets

Change History (4)

comment:1 Changed 7 years ago by jinmei

  • Summary changed from introduce a simpler way of using waked data source from auth tests to introduce a simpler way of using faked data source from auth tests

comment:2 Changed 7 years ago by shane

  • Milestone New Tasks deleted

comment:3 Changed 6 years ago by stephen

  • Milestone set to DNS Outstanding Tasks

comment:4 Changed 6 years ago by tomek

  • Resolution set to wontfix
  • Status changed from new to closed

DNS and BIND10 framework is outside of scope for Kea project.
The corresponding code has been removed from Kea git repository.
If you want to follow up on DNS or former BIND10 issues, see
http://bundy-dns.de project.

Closing ticket.

Note: See TracTickets for help on using tickets.