Opened 7 years ago

Closed 7 years ago

#2361 closed task (complete)

add system tests to start only auth and query for version.bind and authors.bind

Reported by: jreed Owned by: jreed
Priority: medium Milestone: Sprint-20121106
Component: b10-auth Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DNS Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

Add lettuce tests to start only auth and query for version.bind and authors.bind.

Subtickets

Change History (12)

comment:1 Changed 7 years ago by jreed

  • Owner set to jreed
  • Status changed from new to accepted

comment:2 Changed 7 years ago by jreed

  • Owner changed from jreed to UnAssigned
  • Status changed from accepted to reviewing

The branch trac2361 is ready for review for commit 7c40eaf7779f7fb3b80ad141c58f60e69a2f3e4e. It introduces two new files: tests/lettuce/configurations/auth/auth_basic.config.orig and tests/lettuce/features/auth_basic.feature

It was branched at c91bffdd00deb8b7f3ceda9954a84e31c0cfb9f1^ (notice the carat). This is required so it will complete successfully. It fails with later master per ticket #2363.

comment:3 Changed 7 years ago by jreed

  • Milestone changed from New Tasks to Sprint-20121023

Added to current sprint since provides the tests for #2363.

comment:4 Changed 7 years ago by muks

  • Owner changed from UnAssigned to muks

Picking

comment:5 Changed 7 years ago by muks

  • Owner changed from muks to jreed
  • The test is basically ok, as tested before the merge from master branch into the trac2361 branch.
  • I have added a commit on top with minor whitespace updates.
  • An issue here is that lettuce expects BIND 10 to be installed (i.e., available at the install prefix) before b10-auth can serve the static zone. This has to be addressed so that we can override the path to static.zone so it can run using the effects in the srcdir and builddir. If it isn't done as part of this branch, whoever fixes master for this lettuce test should run it without an installed BIND 10 and check if it passes.

comment:6 follow-up: Changed 7 years ago by jelte

er, is it lettuce that wants that or bind10 itself? (i.e. if you run from source, does static.zone work in the first place?)

comment:7 Changed 7 years ago by jreed

We could provide a custom datasrc.spec plugin for cfgmgr? Or I could use bindctl to change the data_sources/CH[0]/params

comment:8 in reply to: ↑ 6 Changed 7 years ago by jreed

  • Owner changed from jreed to UnAssigned

Replying to jelte:

er, is it lettuce that wants that or bind10 itself? (i.e. if you run from source, does static.zone work in the first place?)

Problem was not in lettuce but that the plugins/datasrc.spec point to installed files. I provided a workaround for that in commit 7161d9d899723f1be561125087e1daaf820e80ed

But this will be hard to complete test (lettuce will fail due to other bug), but at least the problem with the missing config is now gone.

This also fixes previously unreported bug that run_bind10.sh using b10-auth component no longer worked.

Last edited 7 years ago by jreed (previous) (diff)

comment:9 Changed 7 years ago by jreed

  • Owner changed from UnAssigned to muks

comment:10 follow-up: Changed 7 years ago by muks

  • Owner changed from muks to jreed

Tested that lettuce now passes without an installed BIND 10 tree (against an older master that passes the lettuce tests).

comment:11 in reply to: ↑ 10 Changed 7 years ago by muks

Replying to muks:

Tested that lettuce now passes without an installed BIND 10 tree (against an older master that passes the lettuce tests).

By this I mean tested against an older master that doesn't have the bug in #2363.

comment:12 Changed 7 years ago by jreed

  • Resolution set to complete
  • Status changed from reviewing to closed

merged to master

Note: See TracTickets for help on using tickets.