Opened 7 years ago

Closed 6 years ago

#2335 closed defect (fixed)

deprecate RRset::setName()

Reported by: jinmei Owned by: muks
Priority: medium Milestone: Sprint-20131015
Component: libdns++ Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DNS Feature Depending on Ticket:
Estimated Difficulty: 4 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

This is a risky interface and makes the class fragile (see #254).
From a quick grep it's now only used in some test cases. I propose
updating these tests without using this knob (that would probably
require expensive copy, but for tests that should be acceptable) and
then deprecate this method.

When we are done, we can also close #254.

Subtickets

Change History (8)

comment:1 Changed 7 years ago by jinmei

  • Milestone set to Next-Sprint-Proposed

comment:2 Changed 7 years ago by jinmei

  • Milestone set to Next-Sprint-Proposed

comment:3 Changed 7 years ago by jinmei

  • Milestone set to Next-Sprint-Proposed

comment:4 Changed 7 years ago by muks

  • Milestone changed from Previous-Sprint-Proposed to Next-Sprint-Proposed

comment:5 Changed 6 years ago by muks

  • Milestone set to Sprint-20131015
  • Status changed from new to reviewing

Up for review. RRset::setName() is not deprecated, but completely removed. We don't have any API stability guarantees yet (it will be discussed during the next F2F meeting in March).

comment:6 Changed 6 years ago by muks

ChangeLog entry for this ticket:

XYZ.    [func]  	muks
	RRset::setName() has now been removed.
        (Trac #2335, git ...)

comment:7 Changed 6 years ago by kean

  • Owner changed from UnAssigned to muks

Everything looks OK on FC19. Go ahead and merge and close.

comment:8 Changed 6 years ago by muks

  • Resolution set to fixed
  • Status changed from reviewing to closed

Merged to master branch in commit c918027a387da8514acf7e125fd52c8378113662:

* c04d82e [2335] Remove RRset::setName()

ChangeLog was also updated. Resolving as fixed. Thank you for the review Kean.

Note: See TracTickets for help on using tickets.