Opened 7 years ago

Closed 7 years ago

#2301 closed enhancement (fixed)

Update ANY_SUB query to use LIKE clause efficiently

Reported by: muks Owned by: muks
Priority: medium Milestone: Sprint-20121009
Component: data source Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DNS Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

See bug #1756 and <https://lists.isc.org/pipermail/bind10-dev/2012-March/003167.html> for discussion.

This fix was actually implemented in trac1756, but bug #1756 is going to be blocked for a while and there's no need to keep the ANY_SUB change pending. So I'm moving just that commit(s) to this bug/branch, and putting it to this sprint.

Subtickets

Change History (4)

comment:1 Changed 7 years ago by muks

  • Owner changed from muks to UnAssigned
  • Status changed from new to reviewing

Up for review.

comment:2 follow-up: Changed 7 years ago by jelte

  • Owner changed from UnAssigned to muks

Changes look OK. The ANY_SUB statement could use a little description comment on what it is supposed to do though.

comment:3 in reply to: ↑ 2 Changed 7 years ago by muks

Replying to jelte:

Changes look OK. The ANY_SUB statement could use a little description comment on what it is supposed to do though.

I've added this comment:

+    // ANY_SUB:
+    // This query returns records in the specified zone for the domain
+    // matching the passed name, and its sub-domains.

comment:4 Changed 7 years ago by muks

  • Resolution set to fixed
  • Status changed from reviewing to closed

Merged to master [fast-forward merge]:

* b9b8993 ([2301] Add comment for ANY_SUB query
* 84d2f37 [2301] Update ANY_SUB query to use LIKE clause efficiently

Resolving as fixed. Thank you for the review Jelte.

Note: See TracTickets for help on using tickets.