Opened 7 years ago

Closed 6 years ago

Last modified 6 years ago

#2300 closed enhancement (fixed)

Implement counters into Xfrin (3/3)

Reported by: naokikambe Owned by: muks
Priority: medium Milestone: Sprint-20131015
Component: xfrin Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DNS Feature Depending on Ticket:
Estimated Difficulty: 5 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

According to StatisticsItems, implement the following statistics items to Xfrin in the same way as #2252 and #2274.

ModuleItemin BIND 9 Statistics XML (tree representation under isc/bind/statistics)Description from BIND 9 ManualImplemented in BIND 10?
Xfrin
xfrin.socket.ipv4.tcp.openserver/ssstat/TCP4OpenIPv4 TCP sockets opened successfullyno
xfrin.socket.ipv6.tcp.openserver/ssstat/TCP6OpenIPv6 TCP sockets opened successfullyno
xfrin.socket.ipv4.tcp.openfailserver/ssstat/TCP4OpenFailIPv4 TCP sockets open failuresno
xfrin.socket.ipv6.tcp.openfailserver/ssstat/TCP6OpenFailIPv6 TCP sockets open failuresno
xfrin.socket.ipv4.tcp.closeserver/ssstat/TCP4CloseIPv4 TCP sockets closedno
xfrin.socket.ipv6.tcp.closeserver/ssstat/TCP6CloseIPv6 TCP sockets closedno
xfrin.socket.ipv4.tcp.connfailserver/ssstat/TCP4ConnFailIPv4 TCP sockets connection failuresno
xfrin.socket.ipv6.tcp.connfailserver/ssstat/TCP6ConnFailIPv6 TCP sockets connection failuresno
xfrin.socket.ipv4.tcp.connserver/ssstat/TCP4ConnIPv4 TCP connections established successfullyno
xfrin.socket.ipv6.tcp.connserver/ssstat/TCP6ConnIPv6 TCP connections established successfullyno
xfrin.socket.ipv4.tcp.senderrserver/ssstat/TCP4SendErrIPv4 TCP sockets send errorsno
xfrin.socket.ipv6.tcp.senderrserver/ssstat/TCP6SendErrIPv6 TCP sockets send errorsno
xfrin.socket.ipv4.tcp.recverrserver/ssstat/TCP4RecvErrIPv4 TCP sockets receive errorsno
xfrin.socket.ipv6.tcp.recverrserver/ssstat/TCP6RecvErrIPv6 TCP sockets receive errorsno

The class XfrinConnection in Xfrin should be revised for counting the above items. In the counter statistics library, XfrinCounter should be revised for adding these items. The related unittest and the lettuce test should be also revised. This ticket depends on #2252 and #2274 because the same statistics library can be used.

Note: For transferring zones in current Xfrin, UDP, Unix domain socket, and binding and accepting socket don't seem to be used. These items are out of scope on this ticket.

Subtickets

Change History (10)

comment:1 Changed 7 years ago by naokikambe

  • Owner set to naokikambe
  • Status changed from new to accepted

A proposed ChangeLog entry:

xxx.   [func]          naokikambe
        New statistics items related to IP sockets added into b10-xfrin:
        open, openfail, close, connfail, conn, senderr, and recverr.
        Their values can be obtained by invoking "Stats show Xfrin" via
        bindctl while b10-xfrin is running.
        (Trac #2300, git TBD)

comment:2 Changed 7 years ago by naokikambe

  • Owner changed from naokikambe to UnAssigned
  • Status changed from accepted to reviewing

The branch is ready for reviewing. This implementation uses a statistics library introduced in #2252.

comment:3 Changed 7 years ago by shane

  • Milestone changed from New Tasks to Next-Sprint-Proposed

comment:4 Changed 7 years ago by naokikambe

  • Owner changed from UnAssigned to naokikambe
  • Status changed from reviewing to accepted

In #2252, we decided to complete a statistics library at first. That includes changes in this ticket. That is, the branch trac2300 needs to be updated. That will be started after completion of #2225. So this ticket's status is being reverted to being accepted.

comment:5 Changed 6 years ago by naokikambe

  • Milestone set to Next-Sprint-Proposed
  • Owner changed from naokikambe to UnAssigned
  • Status changed from accepted to reviewing

trac2300 is ready for reviewing.

I revised the codes according to the current python statistics library.

comment:6 Changed 6 years ago by muks

  • Milestone changed from Next-Sprint-Proposed to Sprint-20131001

comment:7 Changed 6 years ago by muks

  • Owner changed from UnAssigned to muks

comment:8 Changed 6 years ago by naokikambe

Mukund san,

Sorry for my inconvenience. But I cannot continue this ticket. Please continue to review and merge yourself.

Regards,

comment:9 Changed 6 years ago by muks

  • Resolution set to fixed
  • Status changed from reviewing to closed

This branch was reviewed and merged to master branch in commit 4655c110afa0ec6f5669bf53245bffe6b30ece4b:

* 46b7d9d [2300] document in the man page about statistics socket counters introduced in Xfrin
* 5b63f96 [2300] check statistics socket counters for Xfrin in lettuce test
* 499e6f2 [2300] set self.tsig_key_name in XfrinConnection.__init__()
* dc10e21 [2300] add unit tests for statistics socket counters introduced in Xfrin
* 90b12d7 [2300] override some methods of asyncore.dispatcher in XfrinConnection
* f7a3494 [2300] use _master_addrinfo[0] for address family in _get_ipver_str()
* d9ee65e [2300] define new statistics counters in Xfrin spec

Resolving as fixed. Thank you for the work Kambe san.

comment:10 Changed 6 years ago by muks

ChangeLog was also committed and pushed to master branch.

Note: See TracTickets for help on using tickets.