Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#228 closed enhancement (fixed)

review: bindctl could stall if it can't resolve its own host name

Reported by: jinmei Owned by: jinmei
Priority: low Milestone: 05. 3rd Incremental Release: Serious Secondary
Component: ~bind-ctl (obsolete) Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity:
Sub-Project: Feature Depending on Ticket:
Estimated Difficulty: Add Hours to Ticket:
Total Hours: Internal?:

Description

The current implementation of BindCmdInterpreter tries to resolve its own host name into an IPv4 address using socket.gethostbyname to generate a (psuedo?)unique session ID.

I think this is not a good idea. It's not good for several reasons, but most important one would be that the resolution is not always successful or could even stall (e.g.) if the recursive server happens to be unreachable.

As far as I see it, it doesn't have to be an IPv4 address. So I'd suggest to apply the attached patch.

Please review it. I hope it will be included in the next release.

Subtickets

Attachments (1)

bindcmd.diff (597 bytes) - added by jinmei 9 years ago.

Download all attachments as: .zip

Change History (6)

Changed 9 years ago by jinmei

comment:1 Changed 9 years ago by jinmei

  • Status changed from new to reviewing
  • Summary changed from bindctl could stall if it can't resolve its own host name to review: bindctl could stall if it can't resolve its own host name

comment:2 Changed 9 years ago by zhanglikun

Agree, thank you jinmei, please commit it.

comment:3 Changed 9 years ago by shane

  • Owner changed from UnAssigned to jinmei

comment:4 follow-up: Changed 9 years ago by zhanglikun

  • Resolution set to fixed
  • Status changed from reviewing to closed

The patch has been committed in r1096. so close the ticket.

comment:5 in reply to: ↑ 4 Changed 9 years ago by zhanglikun

Replying to zhanglikun:

The patch has been committed in r1096. so close the ticket.

Sorry, the revision number should be r2096. :)

Note: See TracTickets for help on using tickets.