Opened 7 years ago

Closed 6 years ago

#2274 closed enhancement (fixed)

Implement counters into Xfrin (2/3)

Reported by: naokikambe Owned by: naokikambe
Priority: medium Milestone: Sprint-20131001
Component: xfrin Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DNS Feature Depending on Ticket:
Estimated Difficulty: 5 Add Hours to Ticket: 0
Total Hours: 7 Internal?: no

Description

According to StatisticsItems, implement the following statistics items to Xfrin in the same way as #2252.

ModuleItemin BIND 9 Statistics XML (tree representation under isc/bind/statistics)Description from BIND 9 ManualImplemented in BIND 10?
Xfrin
xfrin.ixfr_running(shown in 'rndc status': xfers running)Number of IXFRs in progressno
xfrin.axfr_running(shown in 'rndc status': xfers running)Number of AXFRs in progressno
xfrin.ixfr_deferred(shown in 'rndc status': xfers deferred)Number of deferred IXFRsno
xfrin.axfr_deferred(shown in 'rndc status': xfers deferred)Number of deferred AXFRsno
xfrin.soa_in_progress(shown in 'rndc status': SOA queries in progress)Number of SOA queries in progressno

The class XfrinConnection in Xfrin should be revised for counting the above items. Besides the counter class XfroutCounter should be revised for adding these items. The related unittest and the lettuce test should be also revised. This ticket depends on #2252 because the same statistics library can be used.

Subtickets

Change History (14)

comment:1 Changed 7 years ago by naokikambe

  • Owner set to naokikambe
  • Status changed from new to accepted

comment:2 Changed 7 years ago by naokikambe

A proposed ChangeLog entry:

nnn.   [func]          naokikambe
       New statistics items added into b10-xfrin : ixfr_running, axfr_running,
       ixfr_deferred, axfr_deferred, and soa_in_progress.  Their values can be
       obtained by invoking "Stats show Xfrin" via bindctl when b10-xfrin is
       running.
       (Trac #2274, git TBD)

comment:3 Changed 7 years ago by muks

  • Estimated Difficulty changed from 0 to 5

comment:4 Changed 7 years ago by naokikambe

  • Owner changed from naokikambe to UnAssigned
  • Status changed from accepted to reviewing

The branch is ready for reviewing. This implementation uses a statistics library introduced in #2252.

comment:5 Changed 7 years ago by shane

  • Milestone changed from New Tasks to StatsRedesign

comment:6 Changed 7 years ago by shane

  • Milestone changed from StatsRedesign to Next-Sprint-Proposed

comment:7 Changed 7 years ago by naokikambe

  • Owner changed from UnAssigned to naokikambe
  • Status changed from reviewing to accepted

In #2252, we decided to complete a statistics library at first. That includes changes in this ticket. That is, the branch trac2274 needs to be updated. That will be started after completion of #2225. So this ticket's status is being reverted to being accepted.

comment:8 Changed 6 years ago by naokikambe

  • Milestone set to Next-Sprint-Proposed
  • Owner changed from naokikambe to UnAssigned
  • Status changed from accepted to reviewing

trac2274 is ready for reviewing.

I revised the codes according to the current python statistics library. I couldn't implement ixfr_deferred and axfr_deferred because I couldn't identify where xferring is deferred on the codes. So I remove description regarding these counters from the above proposed change log entry.

nnn.   [func]          naokikambe
        New statistics items added into b10-xfrin : ixfr_running, axfr_running,
        and soa_in_progress.  Their values can be obtained by invoking "Stats
        show Xfrin" via bindctl when b10-xfrin is running.
        (Trac #2274, git TBD)

The some unrelated changes are included in this change but they are trivial and it would be better that they are fixed before this change is merged, I think. However even if you think we should work on a separate ticket about them, please point out.

comment:9 Changed 6 years ago by muks

  • Milestone changed from Next-Sprint-Proposed to Sprint-20131001

comment:10 Changed 6 years ago by muks

  • Owner changed from UnAssigned to muks

I'm currently reviewing this. I think JPRS are in a hurry to get this and #2300 reviewed.

comment:11 follow-up: Changed 6 years ago by muks

  • Owner changed from muks to naokikambe

Hi Kambe-san

The branch looks good mostly. May I suggest the small change in
xfrin_test.py:

-            msg = '%s is expected %s but actually %s' % (name, exp, act)
+            msg = '%s: expected %s but actually got %s' % (name, exp, act)

Also, would it be better to rename ixfr_running and axfr_running to
be ixfr_in_progress and axfr_in_progress to be consistent with the
other key soa_in_progress?

comment:12 in reply to: ↑ 11 Changed 6 years ago by naokikambe

  • Owner changed from naokikambe to muks

Hi Mukund san,

Thank you for reviewing.

The branch looks good mostly. May I suggest the small change in
xfrin_test.py:

-            msg = '%s is expected %s but actually %s' % (name, exp, act)
+            msg = '%s: expected %s but actually got %s' % (name, exp, act)

I've fixed:

6986829 [2274] editorial fix due to reviewer's suggestion

Also, would it be better to rename ixfr_running and axfr_running to
be ixfr_in_progress and axfr_in_progress to be consistent with the
other key soa_in_progress?

I don't think so because there seems to be name consistency with bind9's "rndc status". See StatisticsItems. But even if we decided to rename, I'd like you to do in another ticket. In such case we should rename Xfrout's ones too.

Can I merge?

comment:13 Changed 6 years ago by muks

  • Owner changed from muks to naokikambe

Hi Kambe-san

Yes, please go ahead and merge. :)

comment:14 Changed 6 years ago by naokikambe

  • Resolution set to fixed
  • Status changed from reviewing to closed
  • Total Hours changed from 0 to 7

Thank you.

Merged, closing ticket.

Note: See TracTickets for help on using tickets.