Opened 10 years ago

Closed 9 years ago

#227 closed defect (fixed)

Remove prints without module name

Reported by: jelte Owned by: jelte
Priority: low Milestone:
Component: Unclassified Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity:
Sub-Project: Feature Depending on Ticket:
Estimated Difficulty: Add Hours to Ticket:
Total Hours: Internal?: no

Description

Some modules print messages without [module] at the start. They should not :)

Subtickets

Attachments (2)

bind10_unnamed_print_fixes.patch (15.6 KB) - added by jelte 10 years ago.
bind10_unnamed_print_fixes2.patch (4.2 KB) - added by jelte 10 years ago.

Download all attachments as: .zip

Change History (8)

Changed 10 years ago by jelte

comment:1 Changed 10 years ago by jelte

  • Owner changed from jelte to jreed
  • Status changed from new to reviewing

Attached patch fixes every instance I could find; I did a grep on print, write and cout that did not start with '[', and skipped the directly-run-by-users tools (bindctl, loadzone, host, etc).

Some prints I modified, a few I removed, since they didn't seem useful to me in any form.

Next step is to replace this with real logging ;)

comment:2 Changed 10 years ago by jreed

A few were removed -- maybe just comment out so we can later remember where to change to some debugging/logging.

Changed 10 years ago by jelte

comment:3 Changed 10 years ago by jelte

I forgot to check for std::cerr as well. And found a few more cases, mainly in b10-auth. I also changed [AuthSrv?] to [b10-auth], see fixes2.patch.

comment:4 follow-up: Changed 10 years ago by jreed

fixes2 patch is good. please commit. This also fixes my complaint in #109.

comment:5 in reply to: ↑ 4 Changed 9 years ago by jinmei

  • billable set to 1
  • Internal? unset
  • Owner changed from jreed to jelte

Replying to jreed:

fixes2 patch is good. please commit. This also fixes my complaint in #109.

Why is this ticket still in the review queue?

comment:6 Changed 9 years ago by jelte

  • Resolution set to fixed
  • Status changed from reviewing to closed

No reason, forgot to close it.

Patch (2) has been applied in r2074, closing ticket.

Note: See TracTickets for help on using tickets.