Opened 9 years ago

Closed 9 years ago

#224 closed defect (fixed)

running b10-xfrout in source tree fails

Reported by: jreed Owned by: zhanglikun
Priority: medium Milestone: 05. 3rd Incremental Release: Serious Secondary
Component: xfrout Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity:
Sub-Project: Feature Depending on Ticket:
Estimated Difficulty: 0.0 Add Hours to Ticket:
Total Hours: Internal?: no

Description

File "/opt/pkg/lib/python3.1/socketserver.py", line 400, in __init__
    self.server_bind()
  File "/opt/pkg/lib/python3.1/socketserver.py", line 411, in server_bind
    self.socket.bind(self.server_address)
socket.error: [Errno 2] No such file or directory

This is because it wants to place the file under the install destination and if that is not created yet, it fails.
So when running in source tree should have a temp location for this.

This is maybe related to Trac #151.

Subtickets

Attachments (1)

ticket224.diff (1.4 KB) - added by zhanglikun 9 years ago.
The patch to enable xfrout can be launched in source code tree.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 9 years ago by jreed

This is the same as #206.

Changed 9 years ago by zhanglikun

The patch to enable xfrout can be launched in source code tree.

comment:2 Changed 9 years ago by zhanglikun

If running xfrout in source code tree, the socket file is placed in "B10_FROM_BUILD" folder.(I didn't put the socket file in /tmp folder, since it can make two bind10 run concurrently) Please review the patch.

comment:3 Changed 9 years ago by shane

  • Owner set to jelte
  • Status changed from new to reviewing

Jelte can you have a look, since you've worked on this sort of stuff before.

comment:4 Changed 9 years ago by jelte

  • Owner changed from jelte to zhanglikun

That is, except for some whitespace, exactly the same diff i had in my branch to work around this problem :)

So yeah, looks good.

Only comment is that I think UNIX_SOCKET_FILE is a bad name, since this is specifically for libxfr (which is also a bad name imho). But that may be another ticket (and i want to get the python wrappers merged first, so I suggest we create a separate ticket for this). Oh and while we're at it, should that be a configurable value or do we consider this 'core and unchanging'?

comment:5 Changed 9 years ago by zhanglikun

  • Resolution set to fixed
  • Status changed from reviewing to closed

committed, and a new ticket #236 is created, so close this one.

comment:6 follow-up: Changed 9 years ago by zhanglikun

  • billable set to 0
  • Estimated Difficulty set to 0.0
  • Internal? unset
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopen this ticket, since the change in r2103 was reverted by latter merging,

comment:7 in reply to: ↑ 6 Changed 9 years ago by jinmei

  • Resolution set to fixed
  • Status changed from reopened to closed

Replying to zhanglikun:

Reopen this ticket, since the change in r2103 was reverted by latter merging,

I think it's actually discussed in #283, and this ticket can be closed.

Note: See TracTickets for help on using tickets.