Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#223 closed defect (fixed)

session.py and build directory path change

Reported by: jelte Owned by: jelte
Priority: high Milestone: 04. 2nd Incremental Release: Early Adopters
Component: configuration Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity:
Sub-Project: Feature Depending on Ticket:
Estimated Difficulty: Add Hours to Ticket:
Total Hours: Internal?:

Description

Since session.py now contains a configure-time variable, the path changed from below $srcdir to below $builddir, which presents us with a problem; it is not included in the PYTHONPATH the tests use, and adding builddir to the PYTHONPATH won't fix it, since we then have two directories specifying parts of one module.

There are several quick hacks to fix this but I think making a move towards the third solution suggested in https://lists.isc.org/pipermail/bind10-dev/2010-May/000975.html (and the followup message) would be the best, even though we're in code freeze right now.

Subtickets

Change History (5)

comment:1 Changed 9 years ago by jelte

Ok, there's been a lot of partly unrelated commits to this branch (mainly merges from trunk updates to problems we found gearing up for the release branch), but the important one regarding this ticket are r2049 and r2053 (that last one renamed isc_config.py to bind10_config.py).

So the idea is based upon suggestion 3 in the module and the response by Evan; it defines a one-file base level module that is meant to contain configure-time variables (mostly paths). Currently it only contains the one that is needed to make the tests run, i.e. the default path for the msgq domain socket file.

This module is added straight to the base for the python modules (and specifically not beneath isc/ there), so that we don't get directory conflicts from having a separate build directory.

Later I think we could move everything that's needed for .py.in files in here and move those back to plain .py files, but it is a conceptual change, instead of putting hard defaults in several places we put them in one (bind10_config.py).

I know this is a conceptual change after the freeze, but imo the other two options are to either pull back the whole domain sockets change or live with failing tests (if you build in a separate directory), so I prefer this one gets squeezed in ;)

comment:2 Changed 9 years ago by shane

  • Milestone changed from 05. 3rd Incremental Release to 04. 2nd Incremental Release: Early Adopters
  • Status changed from new to reviewing

Okay, this change looks like the right thing to do. It is a bit of a shame we need to put it in last-minute, but it seems pretty benign.

We should make this system-wide, but for the next release not this one!

comment:3 Changed 9 years ago by jreed

I merged this to trunk in r2063.

comment:4 Changed 9 years ago by shane

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 9 years ago by shane

  • Component changed from Unclassified to configuration
Note: See TracTickets for help on using tickets.